Bug 337651

Summary:	Gwenview import
Product:	[Applications] gwenview	Reporter:	Pierre THOMAS <pithomas>
Component:	importer	Assignee:	Gwenview Bugs <gwenview-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	myriam
Priority:	NOR
Version First Reported In:	4.13.1
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/gwenview/145e0818c190c6cceafb46982ae7704b7a5ee609	Version Fixed/Implemented In:	19.12.0
Sentry Crash Report:

Description Pierre THOMAS 2014-07-21 05:52:40 UTC

Bonjour,
After having imported photos with Gwenview, the default button selected is Delete for deleting photos in the camera. I consider this is dangerous !  To people to whom I teach PC use (Kubuntu replacing Windows XP), I always teach them to:
- first save photos in their PC,
- and to back up them in an external drive or a CD/DVD,
- before deleting the memory card of the camera.

Please change the default action after importing for deleting photos only if we actually and surely want to delete the photos.
But I am surely not a good teacher : one of my "students" (mainly retired people) imported photos in her PC, deleted the photos in the camera, and discovered later that she imported nothing in her PC !  She lost all the photos ... because she asked me assistance later ...

Pierre

Comment 1 Andrew Crouthamel 2018-11-12 02:48:09 UTC

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

Comment 2 Andrew Crouthamel 2018-11-21 04:26:16 UTC

Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

Comment 3 Pierre THOMAS 2018-11-21 06:18:34 UTC

Bonjour,
Considering the need to save photos at least into 2 drives, it is not actually a bug but a very bad logical choice for the default button activated at the end of the import operation.
Before deleting photos in the camera memory after having imported them, we must save them in a second drive. As long this is not done we must keep them in the camera.
Pierre

Comment 4 Nate Graham 2019-10-28 21:49:14 UTC

Git commit 145e0818c190c6cceafb46982ae7704b7a5ee609 by Nate Graham, on behalf of Bart De Vries.
Committed on 28/10/2019 at 21:49.
Pushed by ngraham into branch 'master'.

After import, change default action to "keep" instead of "delete".

Summary:
After importing photos, a dialog pops up which asks whether to
delete or keep the photos on the device/folder from which they
were imported.  Currently, "delete" is the default action.
However, this is quite dangerous for users that don't pay
attention.  Better to present "keep" as the default action.
FIXED-IN: 19.12.0

Reviewers: #gwenview, ngraham

Reviewed By: #gwenview, ngraham

Subscribers: ngraham

Tags: #gwenview

Differential Revision: https://phabricator.kde.org/D24881

M  +3    -3    importer/importdialog.cpp

https://commits.kde.org/gwenview/145e0818c190c6cceafb46982ae7704b7a5ee609