Bug 337406

Summary:	Color picker sample radius limit
Product:	[Applications] krita	Reporter:	Jonathan Ringstad <jwringstad>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	All
Latest Commit:	http://commits.kde.org/calligra/aa8a176e1a9e2e114b3375e1028b86c8f52e78d3	Version Fixed In:

Description Jonathan Ringstad 2014-07-12 19:30:03 UTC

The colorpicker currently has a sample radius limit of 9 pixels. I'd propose raising this limit -- if the user is trying to sample e.g. the skin color from a very high-res photograph (or worse, a photograph that has been up-scaled), sampling a 9px radius circle is still not quite enough to get a good average of the color, due to the camera noise et cetera.

Ideally I think the tool could be able to show a brush outline which indicates the sample radius, although just upping the limit would fix the issue too.

The current workaround I'm using is to just downscale the image 4x or 8x, and then sample.

Reproducible: Always

Comment 1 Halla Rempt 2014-07-15 14:17:06 UTC

I agree -- what would be a good maximum? The maximum is defined in the wdgcolorpicker.ui, changing that fixes the tool. I also agree with the cursor suggestion.

Comment 2 Halla Rempt 2015-01-29 09:41:38 UTC

Git commit aa8a176e1a9e2e114b3375e1028b86c8f52e78d3 by Boudewijn Rempt.
Committed on 28/01/2015 at 15:18.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 900

M  +21   -34   krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc
M  +4    -1    krita/plugins/tools/defaulttools/wdgcolorpicker.ui

http://commits.kde.org/calligra/aa8a176e1a9e2e114b3375e1028b86c8f52e78d3

Comment 3 Halla Rempt 2015-01-29 09:42:18 UTC

Git commit aa8a176e1a9e2e114b3375e1028b86c8f52e78d3 by Boudewijn Rempt.
Committed on 28/01/2015 at 15:18.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 900

M  +21   -34   krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc
M  +4    -1    krita/plugins/tools/defaulttools/wdgcolorpicker.ui

http://commits.kde.org/calligra/aa8a176e1a9e2e114b3375e1028b86c8f52e78d3