Bug 337198

if I create a TransferJob and want to handle the http responsecode, I'll get an empty responsecode it the job fails. See code snippset:

start(const KUrl &url) {
    QMap< QString, QVariant > map;
    map[QLatin1String("errorPage")] = false;
    
    KIO::TransferJob* job = KIO::get( url, KIO::NoReload, KIO::HideProgressInfo );
    job->setMetaData( map );
    connect(job, SIGNAL(result(KJob*)), this, SLOT(slotResult(KJob*)) );
}

slotResult(KJob* job)
{
   KIO::TransferJob *tjob = qobject_cast<KIO::TransferJob *>(job);
   if ( job->error() ) {
       kDebug() << "Fetching failed" << tjob->queryMetaData(QLatin1String("responsecode"));
   } else {
       kDebug() << "all good:)" <<  tjob->queryMetaData(QLatin1String("responsecode"));
   }
}

Reproducible: Always

Actual Results:  
run code and see if the webpage fails with 404 or 500:
"Fetching failed"  ""
and with all went ok:
"all good:)" "200"

you can also set
   map[QLatin1String("errorPage")] = true;

than you get:
for 500:
"Fetching failed"  ""

for 404:
"all  good:)" "404"

for 200:
"all  good:)" "200"

Expected Results:  
also set the responsecode if the job is failing:
"Fetching failed"  "404" / "Fetching failed"  "500"

I think the problem, is that the error is emitted before the responsecode is set to the metadata:
see
bool HTTPProtocol::proceedUntilResponseHeader()
{
  [...]
  while(true) {
       [...]
       //responsecode is used now to deside if authentification is needed, so it is available
       if (!m_isLoadingErrorPage && isAuthenticationRequired(m_request.responseCode)) {
          readBody(true);
      }
      if (m_iError || m_isLoadingErrorPage) {
          return false;
          //i think this should be a break, or set reponsecode before
      } 
  }
  [...]
  //move this line up
  setMetaData(QLatin1String("responsecode"), QString::number(m_request.responseCode));
  return true;
}