| Summary: | default icon theme still oxygen; should be breeze | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kiconthemes | Reporter: | Harald Sitter <sitter> |
| Component: | general | Assignee: | Christoph Feck <cfeck> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | jr, kdelibs-bugs, rdieter, simonandric5, staniek, wbauer1 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kiconthemes/b544c17decc22685207ac11fbd95536e0d798650 | Version Fixed In: | 5.16 |
| Sentry Crash Report: | |||
Not yet, breeze needs to be a lot more complete before it's the default fallback breeze internally falls back to oxygen, so by having the hardcoded default theme oxygen you don't get access to icons provided by the breeze theme but not the oxygen theme unless the kde4breeze migrator runs and twiddles the iconset in kdeglobals to breeze si, vale vale Apps look silly (Kexi: http://i.imgur.com/yIDQGqG.png) when oxygen mimetypes are mixed with breeze icons. Kexi is ready to use breeze by default, and I am not going to add new oxygen icons. Should I hardcode the theme selection? Isn't oxygen hardcoded that there's no way for apps to override at all? I must miss something. For background, please look: http://kde.6490.n7.nabble.com/Breeze-lt-gt-Oxygen-hicolor-icon-replacements-td1588360.html I have theme set to breeze, icons present in $PREFIX/share/apps/kexi/icons/breeze and still icons from $PREFIX/share/apps/kexi/icons/oxygen are loaded. Strace tells me there's no even attempt to test if $PREFIX/share/apps/kexi/icons/breeze exists. Git commit b544c17decc22685207ac11fbd95536e0d798650 by Harald Sitter. Committed on 21/10/2015 at 06:07. Pushed by sitter into branch 'master'. set default theme to breeze rather than oxygen Other framework defaults use Breeze (colors, style..) but icons were still oxygen, making theming in Qt native applications seem off when using the frameworkintegartion plugin while not running inside a session that was coerced into Breeze theming by the kde4breeze theme. This notably applies to rooted applications that operate on a different $HOME but might still be made to load the KDE platformtheme plugin. The breeze icon theme internally uses oxygen as a fallback, so even if an icon is missing in breeze we will continue to find it with breeze as default. CHANGELOG: Change default theme from oxygen to breeze to offer consistency. FIXED-IN: 5.16 REVIEW: 125720 M +1 -1 src/kicontheme.cpp http://commits.kde.org/kiconthemes/b544c17decc22685207ac11fbd95536e0d798650 Harald, you reverted the commit without reopening this bug (and maybe clarify the reason for the revert). Above commit was reverted. Ah yes. Sorry. So, as it turns out Breeze no longer inherits Oxygen which makes software crash that expects certain things to always be there (in oxygen). http://markmail.org/message/eixuwfzsyulus5dm Also more discussion on the topic here https://mail.kde.org/pipermail/kde-frameworks-devel/2015-October/027900.html FYI, the reverted commit still was included in openSUSE's packages, and it caused Bug#360664. We removed it now as well, though. Git commit ad1ead84ee2c3a14363afdb048b3579f3d01fa18 by Aleix Pol. Committed on 17/05/2016 at 10:23. Pushed by apol into branch 'master'. Don't make KIconThemes depend on Oxygen Related: bug 360664 REVIEW: 127817 M +0 -1 src/kiconloader.cpp M +2 -2 src/kicontheme.cpp http://commits.kde.org/kiconthemes/ad1ead84ee2c3a14363afdb048b3579f3d01fa18 The default theme returned is now "hicolor", as per the previous commit. This looks correct, because no actual theme can be the default theme, unless it is also installed. If there are still issues with this resolution, please add a comment. Closing otherwise. |
QString KIconTheme::defaultThemeName() { return QLatin1String("oxygen"); } I very much believe this should be breeze these days? What with breeze inheriting from oxygen and overriding icons... Reproducible: Always