Bug 336507

Summary: ShowUserAgent option repeats mail header names
Product: [Applications] kmail2 Reporter: Khumba <kde-bugs-68795>
Component: UIAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: 4.12.4   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: http://commits.kde.org/kdepim/6f72813453e942804ae1c4224cfb023add46cbbc Version Fixed In: 4.13.3
Sentry Crash Report:

Description Khumba 2014-06-20 15:29:10 UTC 
I am very happy to know that KMail has a ShowUserAgent option documented here:

http://docs.kde.org/stable/en/kdepim/kmail/configure-non-gui-options.html

When I turn it on, the value for the field displayed in the fancy header contains the name of the matching mail header, which is duplicated from the field label ("User-Agent" or "X-Mailer").  Is there a benefit to repeating the name?  It would be nice if it didn't display twice.

(Actually on KDE 4.12.5, not available in the list.)

Reproducible: Always

Steps to Reproduce:
1. kwriteconfig --file ~/.kde4/share/config/kmail2rc --group Reader --key ShowUserAgent true
2. Open a mail with a user agent header.
Actual Results:  
Examples:
"X-Mailer:	X-Mailer: iPad Mail (11B554a)"
"User-Agent:	User-Agent: KMail/1.13.7 (Linux/3.10.17-gentoo; KDE/4.11.2; x86_64; ; )"
"X-Mailer:	X-Mailer: Claws Mail 3.9.3-14-g5f7b75 (GTK+ 2.24.22; x86_64-pc-linux-gnu)"

Expected Results:  
No repetition:
"X-Mailer:	iPad Mail (11B554a)"
"User-Agent:	KMail/1.13.7 (Linux/3.10.17-gentoo; KDE/4.11.2; x86_64; ; )"
"X-Mailer:	Claws Mail 3.9.3-14-g5f7b75 (GTK+ 2.24.22; x86_64-pc-linux-gnu)"
Comment 1 Laurent Montel 2014-06-20 21:54:10 UTC 
Git commit 6f72813453e942804ae1c4224cfb023add46cbbc by Montel Laurent.
Committed on 20/06/2014 at 19:50.
Pushed by mlaurent into branch 'KDE/4.13'.

Fix Bug 336507 - ShowUserAgent option repeats mail header names

FIXED-IN: 4.13.3

M  +2    -2    messageviewer/header/fancyheaderstyle.cpp
M  +2    -2    messageviewer/header/grantleeheaderformatter.cpp

http://commits.kde.org/kdepim/6f72813453e942804ae1c4224cfb023add46cbbc