Summary: | Clone tool crashes if clone source layer is a layer group | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | vanyossi <ghevan> |
Component: | Tools | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73 |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/025c2020cd575f49ce13257ccf5bdd20294eb387 | Version Fixed In: | |
Sentry Crash Report: |
Description
vanyossi
2014-06-19 19:08:44 UTC
No special setup. Created group layer with 2 paint layer childs. Select clone tool Ctrl + click with the group layer highlighted Select a paint layer outside the group (Ie background layer) Crash A little more detail on the backtrace. #0 KisPaintDevice::defaultBounds (this=0x0) at /home/tara/nalaf/nala/program/calligra/krita/image/kis_paint_device.cc:365 #1 0x00007fffd913a056 in KisDuplicateOp::paintAt (this=0x7fff9cac0b10, info=...) at /home/tara/nalaf/nala/program/calligra/krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp:171 #2 0x00007ffff6efe3e7 in KisPaintInformation::paintAt (this=this@entry=0x7fffceff7c60, op=op@entry=0x7fff9cac0b10, distanceInfo=distanceInfo@entry=0x4102260) at /home/tara/nalaf/nala/program/calligra/krita/image/brushengine/kis_paint_information.cc:188 #3 0x00007ffff6f00876 in KisPaintOp::paintLine (this=0x7fff9cac0b10, pi1=..., pi2=..., currentDistance=0x4102260) at /home/tara/nalaf/nala/program/calligra/krita/image/brushengine/kis_paintop.cc:194 #4 0x00007ffff6f000aa in paintBezierCurve (paintOp=0x7fff9cac0b10, pi1=..., control1=..., control2=..., pi2=..., currentDistance=0x4102260) at /home/tara/nalaf/nala/program/calligra/krita/image/brushengine/kis_paintop.cc:141 #5 0x00007ffff6f0012a in KisPaintOp::paintBezierCurve (this=<optimized out>, pi1=..., control1=..., control2=..., pi2=..., currentDistance=<optimized out>) at /home/tara/nalaf/nala/program/calligra/krita/image/brushengine/kis_paintop.cc:164 #6 0x00007ffff77914ad in FreehandStrokeStrategy::doStrokeCallback (this=<optimized out>, data=<optimized out>) at /home/tara/nalaf/nala/program/calligra/krita/ui/tool/strokes/freehand_stroke.cpp:76 #7 0x00007ffff6ecacd9 in KisUpdateJobItem::run (this=0x12bfa40) at /home/tara/nalaf/nala/program/build/master-calligra/krita/image/../../../../calligra/krita/image/kis_update_job_item.h:61 #8 0x00007ffff07605eb in ?? () from /usr/lib64/qt4/libQtCore.so.4 #9 0x00007ffff076c78c in ?? () from /usr/lib64/qt4/libQtCore.so.4 #10 0x00007ffff04d6eda in start_thread (arg=0x7fffceff8700) at pthread_create.c:308 #11 0x00007fffef6c05ad in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:113 Git commit 025c2020cd575f49ce13257ccf5bdd20294eb387 by Dmitry Kazakov. Committed on 20/06/2014 at 06:44. Pushed by dkazakov into branch 'master'. Fixed crash when color picking from a group layer Also fix all the pickers to read from projection() instead of paintDevice(). All nodes in Krita are expected to have projection() which is a visual representation of the node in the stack. The only new behavior this patch introduces is the picking from Filter layers. Now it picks not from their 'selection' (which is a paintDevice()), but from the filtered area cache (projection()). M +1 -1 krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp M +2 -3 krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc M +2 -10 krita/ui/tool/kis_tool_paint.cc http://commits.kde.org/calligra/025c2020cd575f49ce13257ccf5bdd20294eb387 |