| Summary: | Lock Screen: password should get focus after switching users / new session | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Sebastian Kügler <sebas> |
| Component: | Global Theme packages | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bshah, kde |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/a38ebe1241b29f82622a6b439253864daaf5603b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Sebastian Kügler
2014-06-18 00:42:48 UTC
Git commit a38ebe1241b29f82622a6b439253864daaf5603b by David Edmundson. Committed on 25/06/2014 at 16:27. Pushed by davidedmundson into branch 'master'. Clicking on a user selects the password input M +7 -0 lookandfeel/contents/components/UserList.qml M +9 -20 lookandfeel/contents/components/UserSelect.qml http://commits.kde.org/plasma-workspace/a38ebe1241b29f82622a6b439253864daaf5603b A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1440 Git commit 914173a20861bca0102f12090561df489edfa00c by ivan tkachenko. Committed on 10/05/2022 at 21:41. Pushed by ratijas into branch 'master'. sddm-theme: Un-break userSelected signal handling It was lost during refactoring some time ago, but the intention was to give focus to the next item in focus chain assuming that's either a username or a password field. This patch is a less flexible but also less messy and more direct way to achieve practically the same thing. Additionally, explicit Tab focus reason gives a loginButton a nice visual focus which one would expect to see instead of no visual changes. It was tempting to directly call startLogin when password is not required, but that would be surprising when the signal itself is triggered by the Escape key. M +4 -0 lookandfeel/contents/components/SessionManagementScreen.qml M +3 -1 lookandfeel/contents/components/UserDelegate.qml M +9 -0 lookandfeel/contents/lockscreen/MainBlock.qml M +13 -0 sddm-theme/Login.qml https://invent.kde.org/plasma/plasma-workspace/commit/914173a20861bca0102f12090561df489edfa00c |