| Summary: | Rename pattern textbox not tall enough and uses hard-coded font colors [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | DrSlony <bugs> |
| Component: | AdvancedRename-engine | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs, caulier.gilles, metzpinguin, pip.kde |
| Priority: | NOR | ||
| Version: | 4.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/6d4982ebee343bd6f168cab5c4961fc1f57aebdc | Version Fixed In: | 7.5.0 |
| Attachments: |
Rename pattern textbox.
Rename pattern textbox - Oxygen widgets renameinput.patch |
||
|
Description
DrSlony
2014-06-12 12:35:00 UTC
This has not been touched in 4.2.0. Still present in 4.4.0 Created attachment 89246 [details]
Rename pattern textbox.
Theme related?
Underscores visible here... using Version 4.4.0
I tried the following and it made no difference: - digiKam > Settings > Theme - System Settings > Workspace Appearance > Window Decorations - System Settings > Workspace Appearance > Desktop Theme - System Settings > Application Appearance > Style > Widget style - System Settings > Application Appearance > Style > Colors Changing the font - System Settings > Application Appearance > Style > Fonts > General has an influence. When I use DejaVu Sans, Droid Sans or Ubuntu Sans then I don't see the underscores, when I use some other whacky font then I do. Either way, ALL other applications work fine using any of these fonts, so this issue must be resolved within this rename dialog, at least by adding bottom padding. http://i.imgur.com/Ew8okvJ.png Paul, it's easy to verify. Go to digiKam/Configuration dialog into Misc Section, and change widget style. Gilles Caulier Created attachment 89250 [details]
Rename pattern textbox - Oxygen widgets
Changing the widget style that digiKam uses to Oxygen (from qtcurve I normally use) results in the text box becoming too small vertically, as DrSlony reported.
Still present in 4.5.0. Also a problem elsewhere, e.g. in the "customize filename" textbox in the BQM http://i.imgur.com/zgNJJzL.png "[file] _ underscores here _ _ _" Still a problem in 4.6.0. I tried the following widget styles: Oxygen, Phase, Windows, Motif, CDE, Plastique and Cleanlooks. Cleanlooks is the only one where I could see the underscores. Created attachment 90196 [details]
renameinput.patch
This patch fixes the incorrect size of the rename input and change the blue color in light blue.
I tested it with different fonts / sizes and different styles.
Git commit 6d4982ebee343bd6f168cab5c4961fc1f57aebdc by Gilles Caulier. Committed on 03/01/2015 at 10:11. Pushed by cgilles into branch 'master'. Apply patch #90196 from Maik Qualmann to fix advance rename pattern box GUI FIXED-IN : 4.7.0 M +2 -1 NEWS M +7 -3 utilities/advancedrename/advancedrenameinput.cpp M +1 -1 utilities/advancedrename/common/highlighter.cpp http://commits.kde.org/digikam/6d4982ebee343bd6f168cab5c4961fc1f57aebdc Git commit 95b693303f45d5ca360b87fc775916fe635d3656 by Gilles Caulier. Committed on 03/01/2015 at 10:19. Pushed by cgilles into branch 'frameworks'. backport commit # 6d4982ebee343bd6f168cab5c4961fc1f57aebdc from git/master to frameworks branch M +6 -3 utilities/advancedrename/advancedrenameinput.cpp M +1 -1 utilities/advancedrename/common/highlighter.cpp http://commits.kde.org/digikam/95b693303f45d5ca360b87fc775916fe635d3656 |
