Bug 336044

Summary: Father's day is not the 3rd Sunday of June in Belgium (it's the 2nd one)
Product: [Applications] kdepimlibs Reporter: Robert Derochette <shiva3003>
Component: kholidaysAssignee: John Layt <jlayt>
Status: RESOLVED FIXED    
Severity: minor CC: annma, pim-bugs-null, rdieter, roberto.vann.95, william
Priority: NOR Keywords: junior-jobs
Version First Reported In: 4.13.1   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
Latest Commit: http://commits.kde.org/kdepimlibs/633a4a23cc49645fff0c22a5396b5b741303d434 Version Fixed/Implemented In: 4.14.7
Sentry Crash Report:
Attachments: I have corrected the bug in the holidays files
diff file

Description Robert Derochette 2014-06-10 13:46:25 UTC 
In Belgium we celebrate father's day the second Sunday of June (so it was June 8th and not June 15th). However that's not what the calendar displays.
Similarly, mother's day is celebrated the second Sunday of May here. But for mother's day the calendar is encoded correctly (May 11th).

Reproducible: Always
Comment 1 Rex Dieter 2014-06-13 14:16:14 UTC 
Confirmed by some folk on #kde irc today (cc'd already on this bug too).
Comment 2 Christoph Feck 2014-07-20 23:45:23 UTC 
It looks like the be_fr and be_wa files have "third", while only the be_nl has "second" sunday in june, so it should actually be an easy fix.
Comment 3 roberto.vann.95 2015-03-04 11:34:09 UTC 
Created attachment 91410 [details]
I have corrected the bug in the holidays files

I have corrected the files about that holiday in Belgium
Comment 4 roberto.vann.95 2015-03-04 12:34:00 UTC 
Created attachment 91417 [details]
diff file
Comment 5 Laurent Montel 2015-03-05 06:29:39 UTC 
Git commit 633a4a23cc49645fff0c22a5396b5b741303d434 by Montel Laurent.
Committed on 05/03/2015 at 06:28.
Pushed by mlaurent into branch 'KDE/4.14'.

"I corrected the Belgium holidays file to have the right day for the Father's day"

Patch from Roberto Vannucci

REVIEW: 122808
FIXED-IN: 4.14.7

M  +1    -1    kholidays/holidays/plan2/holiday_be_fr
M  +1    -1    kholidays/holidays/plan2/holiday_be_wa

http://commits.kde.org/kdepimlibs/633a4a23cc49645fff0c22a5396b5b741303d434