Bug 335718

Summary:	MANAGER : removing a tag turns entries in "Quick Access List" to "All tags"
Product:	[Applications] digikam	Reporter:	Michael G. Hansen <mike>
Component:	Tags-Manager	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, veaceslav.munteanu90
Priority:	NOR
Version:	4.1.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/57204f0cc849f4e4c6ccc5f2963a1f2f0a0ec4dd	Version Fixed In:	4.3.0
Sentry Crash Report:
Attachments:	Duplicate entries after deletion

Description Michael G. Hansen 2014-06-02 20:36:47 UTC

Reproducible: Always

Steps to Reproduce:
1. Create a tag "testtag" in the tree structure.
2. Add the tag "testtag" to the "Quick Access List".
3. Delete the tag "testtag" in the tree structure.
Actual Results:  
The item that was previously the entry for "testtag" in the "Quick Access List" now reads "All tags". It can not be removed from the "Quick Access List" via the context menu.

Expected Results:  
The removed tag should be removed from the "Quick Access List".

Closing and re-opening the tag editor clears the list from the broken tag references.

Comment 1 Veaceslav Munteanu 2014-06-08 10:31:37 UTC

Confirmed.. investigating...

Comment 2 Veaceslav Munteanu 2014-06-08 12:04:55 UTC

Git commit a7d349d08601f48cacec2389047d3d7c40407b0f by Veaceslav Munteanu.
Committed on 08/06/2014 at 14:59.
Pushed by munteanu into branch 'master'.

M  +3    -1    NEWS
M  +0    -4    digikam/tags/tagsmanager/models/tagmngrlistmodel.cpp
M  +1    -0    digikam/tags/tagsmanager/taglist.cpp

http://commits.kde.org/digikam/a7d349d08601f48cacec2389047d3d7c40407b0f

Comment 3 Michael G. Hansen 2014-06-08 13:54:02 UTC

Created attachment 87069 [details]
Duplicate entries after deletion

Hi Veaceslav,

the entry in the quick access list is now properly deleted. However, if the tag corresponding to the currently active filter is deleted, some other filter, for example "All tags" should be selected IMHO. Currently, no new selection is made.

Also, if I add tags 1,2,3, then set a filter using quick access list on 2, then delete 2, the tree view shows 1,1,3 as shown in the screenshot...

Best regards,

Michael

Comment 4 Veaceslav Munteanu 2014-06-08 14:14:57 UTC

Hmm... actually, with previous commit I set to reset to default All Tags when a selected entry is deleted.. but the is not visual feedback that is selected... I will look into it..

Comment 5 Veaceslav Munteanu 2014-09-02 13:09:25 UTC

Git commit 57204f0cc849f4e4c6ccc5f2963a1f2f0a0ec4dd by Veaceslav Munteanu.
Committed on 02/09/2014 at 13:08.
Pushed by munteanu into branch 'master'.

M  +2    -1    NEWS
M  +4    -0    digikam/tags/tagsmanager/taglist.cpp

http://commits.kde.org/digikam/57204f0cc849f4e4c6ccc5f2963a1f2f0a0ec4dd