Bug 335658

Summary:	Path editing tool visibility is inconsistent
Product:	[Applications] krita	Reporter:	Alicia Boya García (ntrrgc) <ntrrgc>
Component:	Layers/Vector	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	animtim, dimula73, halla, sven.langkamp
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Alicia Boya García (ntrrgc) 2014-06-01 19:24:36 UTC

Sometimes the Path editing tool is visible, so you can select it. Other times not.

The tool seems to work every time the current layer is a vector layer, so I would expect it to be visible every time a vector layer is shown, but that's not the case.

Reproducible: Always

Steps to Reproduce:
1. Open a fresh Krita window.
2. Click calligraphy tool.
3. Draw something.
4. Now you want to edit the path so you go to... oh!
Actual Results:  
The path editing tool is nowhere in the toolbar.
If you select another tool, e.g. the selection tool or the brush tool (which I'm not sure if should be visible when working on a vector layer), then path editing tool appears and you can choose and use it.

When using the selection tool, the path editing tool is visible only when a path is selected and represented as such. However, if I change tool the selection is no longer shown, but I can still click path editing. 

Expected Results:  
I don't know, but something more consistent. I think being able to use the tool everytime a vector layer is selected would be the best for usability: The user would have different tools for different kind of layers, but these tools would not appear or disappear in a seemingly random fashion.

Comment 1 animtim 2014-06-01 20:47:29 UTC

The edit path tool appears not exactly randomly but only when a path with editable nodes is selected. This used to be the same for some other tools, only this one kept this behavior.
So it's not really a bug as it's what the code is expected to do, but more a feature request to make it always visible.
The thing is with making always visible, if you select it without having selected any shape, it becomes useless as you can't select a shape with it.
So it would need a refactoring of the tool to make it possible to select shapes with a modier or something like that..

Comment 2 Alicia Boya García (ntrrgc) 2014-06-01 20:58:43 UTC

Well, the visibility of this tool is not only inconsistent, but indeed buggy. For example, try the following:

1. Use the calligraphy tool to draw a line.
2. Select your new path with the selection tool. Good, the Edit path tool appears.
3. Click on a raster layer.
4. Click on a vector layer.
5. The path is selected but the Edit path tool is no longer visible.

Comment 3 Dmitry Kazakov 2014-06-06 04:33:47 UTC

I guess the bug can be formulated as follows:

1) The path editing tool is visible *only* when there is a shape selected
2) Therefore to edit a shape one can use two methods:
2.1) Activate Default Tool, click on a shape, activate Path Editing Tool, edit the shape
2.2) Activate Default Tool, double-click on a shape, edit the shape

The problem is that double clicking is not easily available on tablets, so the user is left with the first option only, which demands too many clicks.

Proposed solution:

1) Keep the Path Editing Tool available when a Vector Layer is selected and no shape is selected.
2) Allow the Path Editing Tool select a shape to edit when no shape is currently selected.  [0]

[0] - Seems like it is possible internally, since one can switch shapes with this tool.

Comment 4 Halla Rempt 2017-03-01 11:50:29 UTC

At this point, at least in the svg branch, the path editing tool is always visible, so the issue is no longer relevant.