Bug 335565

Summary:	KJumpingCube pollutes log files
Product:	[Applications] kjumpingcube	Reporter:	Martin Walch <walch.martin>
Component:	general	Assignee:	Ian Wadham <iandw.au>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-games-bugs-null
Priority:	NOR
Version First Reported In:	2.1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://invent.kde.org/games/kjumpingcube/commit/eff6021ac777496d76217a889b8230a24d74bfe2	Version Fixed/Implemented In:
Sentry Crash Report:

Description Martin Walch 2014-05-30 01:55:39 UTC

When starting kjumpingcube, much debugging information is printed on command line or into a log file like .xsession-errors:

KJumpingCube::KJumpingCube() CONSTRUCTOR 
CONSTRUCT KCubeBoxWidget: side 3 
CONSTRUCT Game: side 3 

AI_Box CONSTRUCTOR, side = 3

AI_Box CONSTRUCTOR, side = 3
AI_Main CONSTRUCTOR 
AI_Main::setSkill: Player 1 "Kepler" skill 0 maxLevel 0 
AI_Main::setSkill: Player 2 "Kepler" skill 0 maxLevel 0 
KJumpingCube::changeButton ( true true "" 
KJumpingCube::changeButton ( false false "" 
PREFERENCES ACTION is "options_configure" 
GAME ACTION IS 0 
NEW GAME entered: waiting false won? false 
QDEBUG: newGameOK() = true 
GAME LOAD IMMEDIATE SETTINGS entered 
LOAD VIEW SETTINGS 
AI_Main::setSkill: Player 1 "Kepler" skill 2 maxLevel 1 
AI_Main::setSkill: Player 2 "Kepler" skill 4 maxLevel 5 
m_pauseForStep false 
PLAYER 1 settings: skill 2 Kepler true Newton false 
PLAYER 2 settings: skill 4 Kepler true Newton false 
GAME LOAD PLAYER SETTINGS entered 
AI 1 false AI 2 true m_pauseForComputer false 
newGame() loadSettings DONE: waiting false won? false move 0 999999 
setDim ( 3 ) m_side 3 
Entering reset(); 
RESET: activity 0 wait 0 
setUpNextTurn 1 false true pause false wait 0 waiting false 
HUMAN TO MOVE 
KJumpingCube::changeButton ( false false "Your turn" 



I suggest integrating kjumpingcube into kdebugdialog and using kDebug instead of qDebug for that output.

Comment 1 Andrew Crouthamel 2018-11-11 04:25:49 UTC

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

Comment 2 Martin Walch 2018-11-11 09:46:51 UTC

This has not changed (tested in KJumpingCube 2.1 from KDE Applications 18.04.3). While KDebug has become obsolete with KF5 (?), I still think it would be better to integrate this debugging output with the logging infrastructure of KF5, so it is possible to control it using kdebugsettings.

Comment 3 Ian Wadham 2018-11-12 10:32:07 UTC

I was the maintainer of KJumpingCube for a while.

The code for these debugging messages can safely be commented out or deleted. It was not my intention to leave it in. My apologies.

Alternatively, the code can be bracketed by #if AILog > 0 ... #endif, similarly to all the other debugging code I used when re-developing and testing the AI for this game. AILog is defined and documented in the file ai_globals.h.

Comment 4 Bug Janitor Service 2020-12-20 12:22:17 UTC

A possibly relevant merge request was started @ https://invent.kde.org/games/kjumpingcube/-/merge_requests/3

Comment 5 Jazeix Johnny 2020-12-20 21:38:36 UTC

Git commit eff6021ac777496d76217a889b8230a24d74bfe2 by Johnny Jazeix.
Committed on 20/12/2020 at 12:20.
Pushed by aacid into branch 'master'.

Remove useless fprintf on stderr.

M  +0    -13   ai_box.cpp
M  +0    -4    ai_main.cpp

https://invent.kde.org/games/kjumpingcube/commit/eff6021ac777496d76217a889b8230a24d74bfe2