| Summary: | Build fails with giflib 5.1.0 | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Andrea Scarpino <scarpino> |
| Component: | WLM Plugin | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kedgedev, tittiatcoke |
| Priority: | NOR | ||
| Version First Reported In: | 1.7.1 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | 0d4f91d8b957a749ee375be5294e330182c61f4c | Version Fixed In: | 4.14.1 |
| Sentry Crash Report: | |||
Created a review request for a possible solution. https://git.reviewboard.kde.org/r/120047/ Git commit 0d4f91d8b957a749ee375be5294e330182c61f4c by Raymond Wooninck. Committed on 05/09/2014 at 21:40. Pushed by rwooninck into branch 'KDE/4.14'. Make Kopete build with giflib 5.1.0 and up. REVIEW: 120047 M +13 -3 protocols/wlm/wlmchatsession.cpp http://commits.kde.org/kopete/0d4f91d8b957a749ee375be5294e330182c61f4c Andrea, does 4.14.1 build correctly now? |
/build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp: In member function 'void WlmChatSession::convertToGif(const QPixmap&, QString)': /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:560:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)' EGifCloseFile(GifFile); ^ In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0: /usr/include/gif_lib.h:132:5: note: declared here int EGifCloseFile(GifFileType *GifFile, int *ErrorCode); ^ /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:583:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)' EGifCloseFile(GifFile); ^ In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0: /usr/include/gif_lib.h:132:5: note: declared here int EGifCloseFile(GifFileType *GifFile, int *ErrorCode); ^ /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:587:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)' if (EGifCloseFile(GifFile) != GIF_OK) { ^ In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0: /usr/include/gif_lib.h:132:5: note: declared here int EGifCloseFile(GifFileType *GifFile, int *ErrorCode); ^ protocols/wlm/CMakeFiles/kopete_wlm.dir/build.make:307: recipe for target 'protocols/wlm/CMakeFiles/kopete_wlm.dir/wlmchatsession.o' failed make[2]: *** [protocols/wlm/CMakeFiles/kopete_wlm.dir/wlmchatsession.o] Error 1 Reproducible: Always Steps to Reproduce: 1. Update giflib to 5.1.0 2. Try to build kopete Actual Results: Build fails Expected Results: It builds. giflib 5.1.0