Summary: | Fix issues when metadata are loaded by MediaWiki tool [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | H Law <hhclaw.eb> |
Component: | Plugin-WebService-MediaWiki | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | adrian, caulier.gilles |
Priority: | NOR | ||
Version: | 4.11.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kipi-plugins/7d76ea4aae956f7886fb10df6afe3aaf243094c7 | Version Fixed In: | 4.11.0 |
Sentry Crash Report: | |||
Attachments: |
attachment-2274-0.html
patch updated to work with git/master |
Description
H Law
2014-05-28 20:23:17 UTC
H Law, I review your patch from bug #335250 and applied it to code for 4.3.0 release. Can you update patch from this entry to be applied to current implementation from git/master, please Thanks in advance Gilles Caulier Adrian, Another patch for Media Wiki kipi tool to review. Can you take a look please. Thanks in advance Gilles Caulier Looks great. Adrian, Did you review this patch for Media Wiki tool ? Gilles Caulier Created attachment 92753 [details] attachment-2274-0.html I did, I left a comment :) 2015-05-20 11:18 GMT+02:00 Gilles Caulier <caulier.gilles@gmail.com>: > https://bugs.kde.org/show_bug.cgi?id=335493 > > Gilles Caulier <caulier.gilles@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Summary|Fix for issues in loading |Fix issues when metadata > |metadata into mediawiki |are loaded by MediaWiki > |kipi-plugin [patch] |tool [patch] > > --- Comment #4 from Gilles Caulier <caulier.gilles@gmail.com> --- > Adrian, > > Did you review this patch for Media Wiki tool ? > > Gilles Caulier > > -- > You are receiving this mail because: > You are on the CC list for the bug. > Created attachment 92754 [details]
patch updated to work with git/master
Andian, This patch introduce errors at end of uploading. I tried to wikipedia and mediawiki with my account. Without patch it's work, with patch, tool said that you must have right to upload. Why ? Gilles Caulier Sorry, I’ll test the code on Saturday and try to “fix the fix”. Thanks Adrian Gilles Gilles, could you please recheck? I’ve uploaded a file to Wikimedia Commons both with and without the patch, and both succeeded. Without the patch: https://commons.wikimedia.org/wiki/File:Heckert_GNU_white.svg.png With the patch: https://commons.wikimedia.org/wiki/File:Heckert_GNU_%28test%29.png Also, the patch is quite straightforward, and it touches nothing that could possibly affect the upload process, if just affects the uploaded content (the information of the page of each file). Confirmed. I successfully downloaded a file with a without this patch but only in "wikimedia common" server. My previous test was been processed into "wikipedia" server as well, where extra right must be set i suppose. Git commit 7d76ea4aae956f7886fb10df6afe3aaf243094c7 by Gilles Caulier. Committed on 23/05/2015 at 10:19. Pushed by cgilles into branch 'master'. apply patch #92754 to fix metadata on image before to upload file on wikimedia server FIXED-IN: 4.11.0 M +2 -1 NEWS M +67 -59 mediawiki/wmwidget.cpp M +3 -2 mediawiki/wmwidget.h http://commits.kde.org/kipi-plugins/7d76ea4aae956f7886fb10df6afe3aaf243094c7 Git commit 78068fb1e869241432e218b9d11ba3b0a3866442 by Gilles Caulier. Committed on 23/05/2015 at 10:27. Pushed by cgilles into branch 'frameworks'. backport commit #7d76ea4aae956f7886fb10df6afe3aaf243094c7 from git/master to frameworks branch M +65 -57 PORT.KF5/FACTORIZE/mediawiki/wmwidget.cpp M +1 -0 PORT.KF5/FACTORIZE/mediawiki/wmwidget.h http://commits.kde.org/kipi-plugins/78068fb1e869241432e218b9d11ba3b0a3866442 |