Summary: | umbrello crash after Java import via wizard | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Nico Kruber <nico.kruber> |
Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | emmanuel.lepage, mparchet, okellogg, ralf.habacker |
Priority: | NOR | Keywords: | drkonqi |
Version: | 2.13.1 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.14.3 (KDE 4.14.3) | |
Attachments: | KCrash trace from Umbrello 2.13.3 import of cardme-code/src svn r373 |
Description
Nico Kruber
2014-05-28 14:55:55 UTC
it seems, the import does not crash using a single java file using the default, i.e. no, package - my original files I wanted to import reside inside real packages (In reply to comment #0) > [...] > 1) Code -> Code Importing Wizard > 2) select a folder including java files (the "Include Subdirectories" > checkbox does not work!) -> Next This is really _two_ bug reports: I confirm the malfunction of the "Include Subdirectories" checkbox in the Wizard; > 3) Start import > -> it will crash during this import but I cannot confirm the crash. Please attach Java source code for which the crash happens. Git commit c9c85d7e7a4377207e42be29e58453893ce217f3 by Oliver Kellogg. Committed on 29/05/2014 at 11:05. Pushed by okellogg into branch 'master'. (In reply to comment #1) > it seems, the import does not crash using a single java file using the > default, i.e. no, package - my original files I wanted to import reside > inside real packages It might be that the problem is fixed coincidentally by following change but without a reproducer there is no way of knowing. umbrello/codeimport/nativeimportbase.{h,cpp} - Change member m_parsedFiles to `static'. Reason: The files parsed shall be accumulated across all instances of NativeImportBase. See e.g. umbrello/codeimport/javaimport.cpp function spawnImport() : A new JavaImport importer is created for each file. However, m_parsedFiles shall span across all these instances. umbrello/codeimport/nativeimportbase.cpp - Additional fix in function preprocess() : A Java input line such as //***** this is a single line comment ***** was erroneously treated as a multi line comment opener. (Notice the embedded /* which was misinterpreted.) M +11 -0 umbrello/codeimport/nativeimportbase.cpp M +1 -1 umbrello/codeimport/nativeimportbase.h http://commits.kde.org/umbrello/c9c85d7e7a4377207e42be29e58453893ce217f3 (In reply to comment #2) > > [...] > > 1) Code -> Code Importing Wizard > > 2) select a folder including java files (the "Include Subdirectories" > > checkbox does not work!) -> Next > > This is really _two_ bug reports: > I confirm the malfunction of the "Include Subdirectories" checkbox in the > Wizard; By the way, using Code -> Import Project... works fine in this case. (In reply to comment #4) > (In reply to comment #2) > > > [...] > > > 1) Code -> Code Importing Wizard > > > 2) select a folder including java files (the "Include Subdirectories" > > > checkbox does not work!) -> Next > > > > This is really _two_ bug reports: > > I confirm the malfunction of the "Include Subdirectories" checkbox in the > > Wizard; Joris Steyn tried to fix this already, see https://bugs.kde.org/show_bug.cgi?id=327701 and branch work/327701 https://projects.kde.org/projects/kde/kdesdk/umbrello/repository/show?rev=work%2F327701 > By the way, using Code -> Import Project... works fine in this case. or by using treeview->logica viewl->rightclick->import project :-) Git commit 9a16963ece9aeca85a9e678a23ff00f2f59d8730 by Oliver Kellogg. Committed on 29/05/2014 at 11:05. Pushed by okellogg into branch 'KDE/4.13'. (In reply to comment #1) > it seems, the import does not crash using a single java file using the > default, i.e. no, package - my original files I wanted to import reside > inside real packages It might be that the problem is fixed coincidentally by following change but without a reproducer there is no way of knowing. umbrello/codeimport/nativeimportbase.{h,cpp} - Change member m_parsedFiles to `static'. Reason: The files parsed shall be accumulated across all instances of NativeImportBase. See e.g. umbrello/codeimport/javaimport.cpp function spawnImport() : A new JavaImport importer is created for each file. However, m_parsedFiles shall span across all these instances. umbrello/codeimport/nativeimportbase.cpp - Additional fix in function preprocess() : A Java input line such as //***** this is a single line comment ***** was erroneously treated as a multi line comment opener. (Notice the embedded /* which was misinterpreted.) M +11 -0 umbrello/codeimport/nativeimportbase.cpp M +1 -1 umbrello/codeimport/nativeimportbase.h http://commits.kde.org/umbrello/9a16963ece9aeca85a9e678a23ff00f2f59d8730 Hello, To reporoduce this bug. 1. Go to code -> code importing wisird. In programming language, select java Select one or several java file to inport. Click next. Select start import. umbrello should crach Report bug : Application: Umbrello UML Modeller (umbrello), signal: Aborted My configuration : ubuntu 14.04 64 bit umbrello version ubuntu .deb packabge version 4:4.13.-0ubuntu0 Could you fix this bug please ? Best regards mparchet Hello, I have this problem with ubuntu .deb package ; umbrello 4:4.13.3-0ubuntu0.1 My configuration : ubuntu 14.04 LTS 64 bit Could you help me please Besr regards mparchet (In reply to mparchet from comment #8) > Hello, > > I have this problem with ubuntu .deb package ; > umbrello 4:4.13.3-0ubuntu0.1 > > My configuration : > ubuntu 14.04 LTS 64 bit > > Could you help me please > > Besr regards > > mparchet Don't use the Wizard, use Import Project instead. Hello, I'm sorry it doesn't work. For example if I would like import the cardme java project http://sourceforge.net/p/cardme/code/HEAD/tree/ I chose code -> import project I chose ma caedme code project folder Umbrello crash Could you help me please ? Best regards mparchet Created attachment 88865 [details] KCrash trace from Umbrello 2.13.3 import of cardme-code/src svn r373 (In reply to mparchet from comment #10) > Hello, > > I'm sorry it doesn't work. > > For example if I would like import the cardme java project > > http://sourceforge.net/p/cardme/code/HEAD/tree/ > > I chose code -> import project > I chose ma caedme code project folder > > Umbrello crash I confirm using umbrello 2.13.3 : * Start Umbrello * In "Code" -> "Active Language" select "Java" * In "Code" -> "Import Project..." navigate to the cardme-code/src directory of svn checkout * Press <OK> * Crash, backtrace see attachment. Import succeeds when using Umbrello 2.14.x. Hello. Then the ubuntu package is outdated . Could you confirm this ? Best regards mparchet (In reply to mparchet from comment #12) > Hello. > > Then the ubuntu package is outdated . > > Could you confirm this ? According to https://launchpad.net/ubuntu/trusty/+package/umbrello an update does not appear to be in the 14.04 pipeline. In contrast, it looks like the latest umbrello is in 14.10, see https://launchpad.net/ubuntu/utopic/+package/umbrello Hello, Sorry, I have ubuntu 14.04 and it seem that ubuntu 14.10 isen't redy. What I can do ? Chamg ubuntu for kubuntu ? Change my linux distribution for a souce code distribution. Change linux for pc-BSD with ports ? Thanks for your answers Best regardds mparchet Hello, Ubuntu versions do not tend to upgrade packages to new version over its lifecycle. Some exceptions exist, but by rule of the thumb they wont. To solve this problem, there exist something called "PPA" or third party repositories. There is probably a PPA around, but not any of the popular one I know about. Fortunately for you, Umbrello is easy enough to compile. If you are using it, chances are you can also compile it. First, install all the dependencies: sudo apt-get build-dep umbrello # Then compile git clone git://anongit.kde.org/umbrello cd umbrello mkdir build cd build cmake ../ make -j # And run ./src/umbrello Hello, Sorry ubrello dose'nt compile- See bellow gcc error c++: internal compiler error: Processus arrêté (program cc1plus) Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions. c++: internal compiler error: Processus arrêté (program cc1plus) Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions. make[2]: *** [umbrello/CMakeFiles/umbrello.dir/codeimpwizard/codeimportingwizard.cpp.o] Erreur 4 make[2]: *** [umbrello/CMakeFiles/umbrello.dir/dialogs/pages/codeimportoptionspage.cpp.o] Erreur 4 Icould you help me please ? Best regards mparchet |