| Summary: | Visual Polish: Battery Icon consistency | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Andrew Lake <jamboarder> |
| Component: | Battery Monitor | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/2d97851b8ad9991bffb05419fbde3d9888484ce1 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Opportunity to improve icon use consistency
Updated battery.svgz with new icons Patch file to use the the new elements in the battery.svgz theme file |
||
|
Description
Andrew Lake
2014-05-26 16:03:47 UTC
Created attachment 86832 [details]
Opportunity to improve icon use consistency
The network manager is provided as a reference point.
*cough* I posted a thread on the VDG forums about exactly that almost 2 months ago but nobody cared. http://forum.kde.org/viewtopic.php?f=285&t=120513 Unfortunately I completely missed that request on the forums Kai. So sorry. I've responded there. Created attachment 87098 [details]
Updated battery.svgz with new icons
This updated theme file contains the new icon assets from the VDG request.
Created attachment 87099 [details]
Patch file to use the the new elements in the battery.svgz theme file
A patch file for the battery monitor qml files to use the new icon elements in the updated battery.svgz theme file.
Git commit 2d97851b8ad9991bffb05419fbde3d9888484ce1 by Andrew Lake. Committed on 10/06/2014 at 16:10. Pushed by alake into branch 'master'. use new icons in battery.svgz theme file. Also minor updates to improve icon with text vertical alignment. REVIEW:118644 M +30 -2 applets/batterymonitor/contents/ui/BatteryIcon.qml M +10 -8 applets/batterymonitor/contents/ui/BatteryItem.qml M +9 -5 applets/batterymonitor/contents/ui/BrightnessItem.qml M +2 -2 applets/batterymonitor/contents/ui/PopupDialog.qml http://commits.kde.org/plasma-workspace/2d97851b8ad9991bffb05419fbde3d9888484ce1 |