Bug 335377

Summary: Visual Polish: Battery Icon consistency
Product: [Plasma] plasmashell Reporter: Andrew Lake <jamboarder>
Component: Battery MonitorAssignee: Kai Uwe Broulik <kde>
Severity: normal    
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Opportunity to improve icon use consistency
Updated battery.svgz with new icons
Patch file to use the the new elements in the battery.svgz theme file

Description Andrew Lake 2014-05-26 16:03:47 UTC
Consistency could be improved if the same icon used on the panel were used in the in the open applet.

Reproducible: Always
Comment 1 Andrew Lake 2014-05-26 16:05:16 UTC
Created attachment 86832 [details]
Opportunity to improve icon use consistency

The network manager is provided as a reference point.
Comment 2 Kai Uwe Broulik 2014-05-26 16:08:55 UTC
*cough* I posted a thread on the VDG forums about exactly that almost 2 months ago but nobody cared.

Comment 3 Andrew Lake 2014-05-26 16:20:01 UTC
Unfortunately I completely missed that request on the forums Kai. So sorry. I've responded there.
Comment 4 Andrew Lake 2014-06-10 04:51:15 UTC
Created attachment 87098 [details]
Updated battery.svgz with new icons

This updated theme file contains the new icon assets from the VDG request.
Comment 5 Andrew Lake 2014-06-10 04:55:10 UTC
Created attachment 87099 [details]
Patch file to use the the new elements in the battery.svgz theme file

A patch file for the battery monitor qml files to use the new icon elements in the updated battery.svgz theme file.
Comment 6 Andrew Lake 2014-06-10 19:04:12 UTC
Git commit 2d97851b8ad9991bffb05419fbde3d9888484ce1 by Andrew Lake.
Committed on 10/06/2014 at 16:10.
Pushed by alake into branch 'master'.

use new icons in battery.svgz theme file. Also minor updates to improve icon with text vertical alignment.


M  +30   -2    applets/batterymonitor/contents/ui/BatteryIcon.qml
M  +10   -8    applets/batterymonitor/contents/ui/BatteryItem.qml
M  +9    -5    applets/batterymonitor/contents/ui/BrightnessItem.qml
M  +2    -2    applets/batterymonitor/contents/ui/PopupDialog.qml