Summary: | Rendering of kwin context menu is broken | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Elias Probst <mail> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Rendering issue of kwin contextmenu
Context menu without shadow |
Description
Elias Probst
2014-05-24 15:40:00 UTC
It seems this is not strictly related to kwin's context menu. The same happens e.g. for the context menu in a text input in systemsettings or kinfocenter. The context menu on the plasmashell desktop doesn't have the black-filled rounded corners, but is missing any shadows. I actually couldn't find a single KF5-based application yet where the context menus are rendered as they should be. Context menus in Thunderbird/Firefox are rendered just fine. @Thomas: Thanks for the information. Looks like it was just a little too late for 5.3.0. Will apply this fix locally then until 5.3.1 is released. Downstream bug for Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=511388 Re-opening as the initially described issue is only partially fixed by the Qt patch. The black corners are gone, but the menus remain uncomposited (at least no shadow is rendered). Do they have a shadow property?* Can you upload a new screenshot? *That's gonna be tricky, since you can't pick the window. Run "xev -event substructure -root" and open the window, there'll be a "MapNotify" event (eventually some ;-) eg: MapNotify event, serial 18, synthetic NO, window 0x29c, event 0x29c, window 0x60040a, override YES next, run "sleep 5; xprop -id 0x60040a | grep -i shadow", with "0x60040a" being the actual id you obtained, and open the popup within the next 5 seconds, then wait until the xprop command finishes. Created attachment 86821 [details]
Context menu without shadow
It doesn't have a shadow property.
The other properties (without piping the output through grep):
_NET_WM_USER_TIME(CARDINAL) = 35512316
WM_TRANSIENT_FOR(WINDOW): window id # 0x1400002
XdndAware(ATOM) = BITMAP
_NET_WM_NAME(UTF8_STRING) = "KWin"
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x3e, 0x7e, 0x0, 0x0
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
_XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1
WM_CLIENT_LEADER(WINDOW): window id # 0x1400002
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
_NET_WM_PID(CARDINAL) = 3002
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 21786105
WM_CLASS(STRING) = "kwin", "kwin"
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_NORMAL_HINTS(WM_SIZE_HINTS):
user specified location: 2008, 1492
user specified size: 210 by 190
window gravity: Static
Do other context menus have the shadow for you? xcb_flush, https://codereview.qt-project.org/#change,85654 Elias' arms. Both. ;-) (In reply to comment #8) > Do other context menus have the shadow for you? See comment#1: > It seems this is not strictly related to kwin's context menu. > The same happens e.g. for the context menu in a text input in systemsettings or kinfocenter. > The context menu on the plasmashell desktop doesn't have the black-filled rounded corners, but is missing any shadows. > I actually couldn't find a single KF5-based application yet where the context menus are rendered as they should be. > Context menus in Thunderbird/Firefox are rendered just fine. This statement remains true except of the "black-filled rounded corners", so it's only the shadows/compositing missin. @Thomas: Rebuilding now with the xcb_flush patch, will update once the build is done + I tested it. Rebuilt now dev-qt/qtgui-5.3.0 with the patch from https://codereview.qt-project.org/#change,85654, restarted kwin and still have no shadows in kwin's windeco context menu. The same for context menu in applications (restarted them after the rebuild). oxygen might set the shadow property on the window WId (the non-ARGB one) Dropping FF/TB and to rephrase Martins question: does any Qt/Oxygen styled popup menu (kwrite, kmail, dolphin, ...) have shadows? > Dropping FF/TB and to rephrase Martins question: does any Qt/Oxygen styled popup menu (kwrite, kmail, dolphin, ...) have shadows?
Running a purely Qt5/KF5-based environment currently, so I don't have many applications to test this, but so far it was the same (no shadow) for at least konsole, khelpcenter, systemsettings, plasmashell, ksysguard, kinfocenter, …
To answer this question: No
I don't have Oxygen for Qt4 available right now to test this.
just looked at the context menu of KWin (Qt5) and KMail (Qt4): no shadow for KWin, shadow for KMail. Looks like an Oxygen issue to me. I fixed that problem in Qt. (In reply to Martin Gräßlin from comment #15) > I fixed that problem in Qt. Can you point me to the commit? I'd like to give the patch a try to see if it works for me. That should be https://codereview.qt-project.org/84169 |