| Summary: | Proposed minor fixes to MediaWiki tool [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | H Law <hhclaw.eb> |
| Component: | Plugin-WebService-MediaWiki | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | adrian, caulier.gilles, reuben_p |
| Priority: | NOR | ||
| Version: | 4.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kipi-plugins/7b61bb7d9b7b8722db990ce42dd8aa0eebc8d2bc | Version Fixed In: | 4.3.0 |
| Sentry Crash Report: | |||
| Attachments: | Here is the patch referred to in the report | ||
Created attachment 86790 [details]
Here is the patch referred to in the report
Adrian, Do you seen this patch about MediaWiki tool ? Gilles Caulier This is a patch to the MediaWiki code in digiKam, not to the libmediawiki library itself. That said, I’ve reviewed the changes and they seem alright. So +1 on my side. Git commit 7b61bb7d9b7b8722db990ce42dd8aa0eebc8d2bc by Gilles Caulier.
Committed on 15/08/2014 at 07:12.
Pushed by cgilles into branch 'master'.
Apply patch from H Law about to improve MediaWiki tool :
(a) The new feature of removing metadata / geo option would not work (i.e. metadata will continue to be uploaded) IF the global option for writing metadata is set to sidecar only. The patch rectify the issue.
(b) Use the {{Coord}} template instead of the {{Location dec}} template in the uploaded descriptions.
(c) Allow the user to override the upload comment (currently fixed to "Upload via KIPI uploader"). An additional input box is provided for the purpose.
(d) Allow an option not to provide the license part. (Mainly for use in private wikis)
FIXED-IN: 4.3.0
M +2 -1 NEWS
M +27 -10 mediawiki/wikimediajob.cpp
M +1 -1 mediawiki/wikimediajob.h
M +126 -100 mediawiki/wmwidget.cpp
M +7 -6 mediawiki/wmwidget.h
M +23 -16 mediawiki/wmwindow.cpp
M +1 -1 mediawiki/wmwindow.h
http://commits.kde.org/kipi-plugins/7b61bb7d9b7b8722db990ce42dd8aa0eebc8d2bc
Part b should probably be reverted for WikiMedia Commons, as the use of the {{coord}} template places the item in the category Media with erroneous locations.
https://commons.wikimedia.org/wiki/Template:Coord
|
I would like to submit a patch, which addresses several issues - (a) The new feature of removing metadata / geo option would not work (i.e. metadata will continue to be uploaded) IF the global option for writing metadata is set to sidecar only. The patch rectify the issue. (b) Use the {{Coord}} template instead of the {{Location dec}} template in the uploaded descriptions. (c) Allow the user to override the upload comment (currently fixed to "Upload via KIPI uploader"). An additional input box is provided for the purpose. (d) Allow an option not to provide the license part. (Mainly for use in private wikis) Reproducible: Always I am new to Digikam and the internal working of KIPI plugins. The minor patch was made just to scratch my own itch. Shared in case this is useful for incorporating in future versions. In any case a big thank you for the very useful piece of software!