| Summary: | Clock should use Text::fontSizeMode | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | David Edmundson <kde> |
| Component: | Digital Clock | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/3fec017438b72d96028dd1eb33beb838ec047a11 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
David Edmundson
2014-05-21 16:41:08 UTC
What nonsense in particular are you referring to? sizehelper and geotimer I think the sizehelper would still be needed though as you need to actually somehow get the width/height first in order to use the sizeMode. Height you can get from the panel height but you also need constant width otherwise the plasmoid size will jump when time changes, making your whole panel contents move all the time. How would you suggest the width is computed then? I think you're right: sizehelper is needed. but death to geotimer ! maybe? Alright, I'll see what I can do. Git commit 3fec017438b72d96028dd1eb33beb838ec047a11 by Martin Klapetek. Committed on 23/05/2014 at 15:23. Pushed by mklapetek into branch 'master'. [digital-clock] Replace sizing timer with fontSizeMode property QML offers a fontSizeMode setting that scales font to the available size. This replaces the sizing timer we had in clock with that property. REVIEW: 118274 M +17 -34 applets/digital-clock/package/contents/ui/DigitalClock.qml http://commits.kde.org/plasma-workspace/3fec017438b72d96028dd1eb33beb838ec047a11 |