Bug 335094

Summary:	Fuzzy clock widget uses straight quote in “o’clock”
Product:	[Unmaintained] plasma4	Reporter:	jakyperos
Component:	widget-fuzzyclock	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	agronick, cfeck, lueck
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	git master
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kdeplasma-addons/baf01118a50d88cb61b1720b35ccb304f13f46c7	Version Fixed/Implemented In:	5.1
Sentry Crash Report:

Description jakyperos 2014-05-20 18:57:06 UTC

When the time is close to the hour, the fuzzy clock widgets displays, for example:
Nine o'clock

It would look a lot better with a real apostrophe:
Nine o’clock

Reproducible: Always

Steps to Reproduce:
1. Add fuzzy clock widget to panel.
2. Set fuzziness to level 1 or 2.
3. Wait till the end of the current hour.
Actual Results:  
“Nine o'clock” is displayed.

Expected Results:  
It should be: “Nine o’clock”.

I believe the relevant source file is:
kdeplasma-addons/applets/fuzzy-clock/fuzzyClock.cpp

Comment 1 Christoph Feck 2014-05-20 21:30:10 UTC

Makes a nice junior job for someone looking how to checkout master branch and creating a patch.

Comment 2 Kyle Agronick 2014-08-07 01:46:06 UTC

I fixed this bug the fix can be found here https://git.reviewboard.kde.org/r/119637/

Comment 3 Christoph Feck 2014-08-07 10:48:55 UTC

Burkhard, since it touches translatable strings, can you approve/commit it? If yes, for which branch? 4.14 is going to be tagged on Aug 13th.

Comment 4 Burkhard Lück 2014-08-12 05:14:04 UTC

4.14 is in message freeze since Wednesday, June 25.

Commiting this now to 4.14 is allowed only with approval from the translators on kde-i18n-doc@kde.org.

Please ask for approval on kde-i18n-doc@kde.org

Comment 5 Kai Uwe Broulik 2014-09-22 18:22:27 UTC

Git commit baf01118a50d88cb61b1720b35ccb304f13f46c7 by Kai Uwe Broulik.
Committed on 22/09/2014 at 18:17.
Pushed by broulik into branch 'master'.

Use a massive list for every time used

This enables the translators to give a precise translation for the colloquial time,
no need for scripting KLocalizedString anymore.

Also use proper typographical apostrophe for o'clock.

FIXED-IN: 5.1
Related: bug 165612

M  +149  -37   applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml

http://commits.kde.org/kdeplasma-addons/baf01118a50d88cb61b1720b35ccb304f13f46c7