Summary: | CMakeLists.txt is outdated | ||
---|---|---|---|
Product: | [Applications] kajongg | Reporter: | Martin Walch <walch.martin> |
Component: | general | Assignee: | Wolfgang Rohdewald <wolfgang> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde-games-bugs, wolfgang |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kajongg/f6c50a41d8fccfb212abf1f3e1caa2460b73c18f | Version Fixed In: | 4.13.2 |
Description
Martin Walch
2014-05-20 00:50:01 UTC
You are right, but only for the master branch. Which surprises me, I was assuming that cmake is only used by packagers. The release branches KDE/4.X should not have such a problem, and at least configdialog.py is indeed not used in any of them. configdialog.py and others are only used when there is no usable PyKDE binding installed, they contain stuff that emulates PyKDE (not yet as good as I want to). This lets me run kajongg on Windows as a pure Qt program, and it might perhaps help with the migration to Qt5/KF5 qt*.py hides differences between qt4 and qt5. (In reply to comment #1) > You are right, but only for the master branch. Which surprises me, I was > assuming that cmake is only used by packagers. > > The release branches KDE/4.X should not have such a problem, and at least > configdialog.py is indeed not used in any of them. Gentoo builds KDE packages using the cmake infrastructure. I actually came across the problem, because I can not get kajongg to work on Gentoo with the latest ebuild which uses the 4.13.1 source tarball. Are you sure 4.13.1 should work and this should be fixed downstream? Git commit 985bf653088e53483722009f6277dd439423fbfa by Wolfgang Rohdewald. Committed on 21/05/2014 at 06:06. Pushed by wrohdewald into branch 'KDE/4.13'. CMakeLists.txt: add missing .py files FIXED-IN: 4.13.2 M +5 -0 CMakeLists.txt http://commits.kde.org/kajongg/985bf653088e53483722009f6277dd439423fbfa Git commit f6c50a41d8fccfb212abf1f3e1caa2460b73c18f by Wolfgang Rohdewald. Committed on 21/05/2014 at 06:06. Pushed by wrohdewald into branch 'master'. CMakeLists.txt: add missing .py files FIXED-IN: 4.13.2 M +5 -0 CMakeLists.txt http://commits.kde.org/kajongg/f6c50a41d8fccfb212abf1f3e1caa2460b73c18f |