Bug 335017

Summary:	konquest emits warning "QStateMachine::addState: state has already been added to this machine" when starting a new game
Product:	[Applications] konquest	Reporter:	Martin Walch <walch.martin>
Component:	general	Assignee:	Pierre Ducroquet <pinaraf>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kde-games-bugs
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/konquest/968ce5cd228ff9906b7aed0c936ddc06d36581da	Version Fixed In:
Sentry Crash Report:
Attachments:	fix proposal

Description Martin Walch 2014-05-19 00:19:10 UTC

Created attachment 86703 [details]
fix proposal

When starting a new game in konquest, the warning

QStateMachine::addState: state has already been added to this machine

appears for each player. This is because in the constructor of the common Player class, the new object is added to the QStateMachine, and in LocalGame::buildMachine(), they are added again.

Comment 1 Martin Walch 2014-07-23 23:20:56 UTC

I just added the patch to the review board:

https://git.reviewboard.kde.org/r/119436/

Comment 2 Albert Astals Cid 2014-08-10 22:40:42 UTC

Git commit 968ce5cd228ff9906b7aed0c936ddc06d36581da by Albert Astals Cid, on behalf of Martin Walch.
Committed on 10/08/2014 at 22:39.
Pushed by aacid into branch 'KDE/4.14'.

fix for bug #335017: konquest emits warning "QStateMachine::addState: state has already been added to this machine" when starting a new game
REVIEW: 119436

M  +5    -6    localgame.cpp

http://commits.kde.org/konquest/968ce5cd228ff9906b7aed0c936ddc06d36581da