Bug 334826

Summary:	Krita doesnt read many PS brushes
Product:	[Applications] krita	Reporter:	JayJay <mnkyshield>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/5b4ee959d56347255ebbda2589593d8cedb8843a	Version Fixed In:
Sentry Crash Report:

Description JayJay 2014-05-15 17:37:18 UTC

After updating to git master today Krita cant read many PS brushes which it cud read earlier. I cant import them thru the resource manager as well. If I revert back to commit e6c2ad7b then all brushes are seen by krita properly.

Reproducible: Always

Steps to Reproduce:
1. Update to git master
2. Start Krita
3. Look in predefined brushes
Actual Results:  
Cant read many PS brushes

Expected Results:  
Krita used to read all PS brushes

Comment 1 Halla Rempt 2014-05-16 08:52:02 UTC

Ah, that is very likely my fault. Thanks for testing, I'll try to fix it.

Comment 2 Halla Rempt 2014-05-16 08:54:11 UTC

Hm, turns out I don't have any to test with, can you share a few with me that are known to fail?

Comment 3 JayJay 2014-05-16 16:53:50 UTC

Sure, I am linking two files that dont show up,

https://www.dropbox.com/s/4nukv66yd4q9clx/Spaceship_Brushes_by_sdavis75.abr
https://www.dropbox.com/s/9g869fbjct63u5o/Trees_by_Horhew.abr

Comment 4 Halla Rempt 2014-05-17 06:43:50 UTC

Git commit 5b4ee959d56347255ebbda2589593d8cedb8843a by Boudewijn Rempt.
Committed on 17/05/2014 at 06:40.
Pushed by rempt into branch 'master'.

M  +2    -0    krita/plugins/paintops/libbrush/kis_abr_brush_collection.cpp

http://commits.kde.org/calligra/5b4ee959d56347255ebbda2589593d8cedb8843a