Bug 334612

Ok I understand bug.
I will fix it soon.

Sorry for not recognizing this earlier: it seams that this bug only happens if you select text from the signature and press enter. It works fine with the normal email text.

Git commit dc110d65dcc38af6989ceb3d503271302539c937 by Montel Laurent.
Committed on 12/05/2014 at 05:46.
Pushed by mlaurent into branch 'KDE/4.13'.

Fix Bug 334612 - Selecting text and pressing enter doesn't replace the text but only adds a newline

FIXED-IN: 4.13.1

M  +1    -1    messagecomposer/composer/kmeditor.cpp
M  +1    -1    pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp
M  +22   -20   pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp

http://commits.kde.org/kdepim/dc110d65dcc38af6989ceb3d503271302539c937

No, the bug is sadly not fixed. :-(

Running 4.13.1 under Fedora (kde-unstable packages).

(In reply to comment #4)
> No, the bug is sadly not fixed. :-(
> 
> Running 4.13.1 under Fedora (kde-unstable packages).

So still update it :)
It's fixed I already tested it.
As you can see in commit:
" -            if(d->mAutoCorrection && !isLineQuoted(textCursor().block().text())) {

   +        if(d->mAutoCorrection && !isLineQuoted(textCursor().block().text()) && !textCursor().hasSelection()) {
"

=> if selection we don't make autocorrection
=> it's fixed.

(In reply to comment #5)
> (In reply to comment #4)
> > No, the bug is sadly not fixed. :-(
> > Running 4.13.1 under Fedora (kde-unstable packages).
> So still update it :)

He says he's already running 4.13.1, so to what version is he supposed to update?

I'm also running 4.13.1 on Kubuntu 14.04 (About dialog: KMail Version 4.13.1 unter KDE 4.13.1) and bug clearly is not fixed.

The behaviour if ENTER is pressed is as expected if the line is quoted (which seems to be what your if statement checks), but it's still wrong if a line is not quoted. In this case, an ENTER or SPACE does not replace the selected text, but simply adds the newline or space character in front of or after the selected text.

Mh, can someone re-open this bug, or should I add a new one for KDE 4.13.1?

Also this bug looks like a duplicate of Bug 334571 which also is not fixed in KDE 4.13.1, so maybe it should be tagged / linked accordingly.

Additional information: If the selection spans multiple lines, some quoted and some not, the behaviour if ENTER or SPACE is pressed does not depend on the selected area but on the row the cursor is positioned in.

If if (parts of) three lines are selected and the cursor is positioned in a quoted line, pressing ENTER or SPACE will replace the selected text by a newline or space character, as expected.

If if (parts of) three lines are selected and the cursor is positioned in a not-quoted line, pressing ENTER or SPACE will simply add a newline or space character in front of or after the selection, contrary to the behaviour of every other GUI text editor I know.

> => if selection we don't make autocorrection
> => it's fixed.

This bug is called "Selecting text and pressing enter doesn't replace the text but only adds a newline" and this is a bug that has not been fixed. Maybe there was another bug about autocorrection but this is not it.

It's "sort of" fixed if
a) text is selected and
b) you press enter (or space) while the cursor is located in a quoted line.

In this case, the selection is replaced.

If, however, some text is selected and the cursor is NOT in a quoted line while you press enter (or space), then the bug prevails and the selection is NOT replaced.

I'll add to comment 10 that when you select several lines with keyboard, especially at the end of the email you're replying to, the cursor is typically not on the quoted line, and pressing enter does not remove the selected text. This is really annoying.

This bug is fixed in kMail 4.14.2 and 4.14.6, as far as I can tell, and probably can be closed now. :-)