Bug 334532

Summary:	Importing PGP keys from websites should be easier
Product:	[Applications] kleopatra	Reporter:	tlhackque
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	REPORTED ---
Severity:	wishlist	CC:	montel, mutz, samir, tlhackque
Priority:	NOR
Version:	2.2.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Other
URL:	https://www.isc.org/downloads/software-support-policy/openpgp-key/
Latest Commit:		Version Fixed In:

Description tlhackque 2014-05-08 21:07:44 UTC

It should be possible to import a public key from a website without putting it into a file.  This is a pretty common (and recommended) method for key distribution.

For example,  ISC distributes several PGP keys on https://www.isc.org/downloads/software-support-policy/openpgp-key/

It ought to be possible to copy & paste these into Kleopatra.  It isn't.

Instead, one has to copy and paste into a file, import, then delete the file.

I'd like an 'import from clipboard' option, or a text box to paste these into.

Thanks for your consideration.


Reproducible: Always

Comment 1 Samir Nassar 2014-07-12 21:32:11 UTC

Confirm.

Comment 2 Samir Nassar 2014-07-13 07:41:11 UTC

Actually, the desired feature works from the system tray. If you highlight and copy a PGP key and then right click on the kleopatra system tray entry, go to the Clipboard entry, then you can import from clipboard.

This isn't optimal though, at it takes three clicks for a functionality than could be done with two.

Comment 3 Laurent Montel 2014-07-15 15:08:29 UTC

(In reply to Samir Nassar from comment #2)
> Actually, the desired feature works from the system tray. If you highlight
> and copy a PGP key and then right click on the kleopatra system tray entry,
> go to the Clipboard entry, then you can import from clipboard.
> 
> This isn't optimal though, at it takes three clicks for a functionality than
> could be done with two.

How it can take two ?

Comment 4 Samir Nassar 2014-07-15 15:23:46 UTC

The actions under the clipboard entry on the menu that pops up when right-clicking on the Kleopatra taskbar entry could all be moved to the main taskbar menu and relabelled : ... from clipboard.

Ultimately though, if this functionality moves to the main Kleopatra window this matters less.

Comment 5 Laurent Montel 2014-07-15 20:43:32 UTC

As you see I fixed Bug 332069

Is it enough ?

Regards

Comment 6 Samir Nassar 2014-07-15 20:51:14 UTC

I'm not set up to test it, and my brain isn't good enough to visualize the code changes you made, but I read through the code and I think I get the gist of it.

So, that's a qualified yes.

Comment 7 tlhackque 2014-07-15 21:03:36 UTC

(In reply to Laurent Montel from comment #5)
> As you see I fixed Bug 332069
> 
> Is it enough ?
> 
> Regards

If there's a place to find a kit with this change, I'll try it and see if it resolves my issue.

What I'd really like to see is a text box that I can drag a key into from a browser window or paste from a clipboard copy.

Note that the former is zero clicks (aside from the select & drag).

Comment 8 Laurent Montel 2014-07-16 07:01:34 UTC

It'"s in 4.14beta2.
"What I'd really like to see is a text box that I can drag a key into from a browser window or paste from a clipboard copy."
We can copy and now in mainwindow we have menu to get info from clipboad.

but dnd not sure how we can do it.

Comment 9 tlhackque 2014-07-16 09:28:57 UTC

(In reply to Laurent Montel from comment #8)
> It'"s in 4.14beta2.
Thanks.  Where can I obtain this?

> "What I'd really like to see is a text box that I can drag a key into from a
> browser window or paste from a clipboard copy."
> We can copy and now in mainwindow we have menu to get info from clipboad.
> 
If you added a text box, one could paste from clipboard without having to look for a menu item.  That would be an improvement

> but dnd not sure how we can do it.

You setup a DragDrop event handler on the text box, which extracts the text (or a file) from the clipboard.  Also, see http://answers.microsoft.com/en-us/ie/forum/ie8-windows_other/dragging-dropping-pictures-text-no-more-in/7e6116cf-92b1-4c99-98b3-52d0169d4c50 - you'll need to setup a DnD policy to allow drops from protected mode IE to Kleopatra.

Comment 10 Laurent Montel 2014-07-16 11:52:17 UTC

(In reply to tlhackque from comment #9)
> (In reply to Laurent Montel from comment #8)
> > It'"s in 4.14beta2.
> Thanks.  Where can I obtain this?

Good question :)

> > "What I'd really like to see is a text box that I can drag a key into from a
> > browser window or paste from a clipboard copy."
> > We can copy and now in mainwindow we have menu to get info from clipboad.
> > 
> If you added a text box, one could paste from clipboard without having to
> look for a menu item.  That would be an improvement

I will look at how to do.

> > but dnd not sure how we can do it.
> 
> You setup a DragDrop event handler on the text box, which extracts the text
> (or a file) from the clipboard.  Also, see
> http://answers.microsoft.com/en-us/ie/forum/ie8-windows_other/dragging-
> dropping-pictures-text-no-more-in/7e6116cf-92b1-4c99-98b3-52d0169d4c50 -
> you'll need to setup a DnD policy to allow drops from protected mode IE to
> Kleopatra.

I use Qt not windows API :) So if qt supports it it's ok otherwise...