| Summary: | Panel positions in multiscreen are not remembered/placed depending on mouse position | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Martin Klapetek <mklapetek> |
| Component: | generic-multiscreen | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/9f9ba633c1f0525a62fa82e53ec0b68043d91277 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 328593 | ||
|
Description
Martin Klapetek
2014-05-08 09:36:25 UTC
Git commit 2052b811403e52bb80d1abdaf87f91ae257e0e9c by Aleix Pol. Committed on 08/05/2014 at 13:38. Pushed by apol into branch 'master'. Remove hack for early initialization of PanelView This broke screenForContainment because the Panel didn't know where it would be placed when the panel is being set. This shouldn't be the case anymore. Related: bug 334500 M +3 -22 shell/panelview.cpp M +1 -1 shell/panelview.h M +4 -3 shell/shellcorona.cpp http://commits.kde.org/plasma-workspace/2052b811403e52bb80d1abdaf87f91ae257e0e9c I cannot reproduce it here, maybe that commit fixed the problem? Actually it already worked properly before... Anyway, can you try again maybe? Yup, seems fixed now. After more testing, it's doesn't seem to be fixed yet :/ Here's a video: https://dl.dropboxusercontent.com/u/6761102/plasma_multiscreen.mkv It shows that the desktops are switching moreless randomly between screens. Is this with a set primary screen? You can check this by running "xrandr -q" and seeing whether you have a line such as: "LVDS1 connected primary 1280x800+0+0 (normal left inverted right x axis y axis) 261mm x 163mm" Note the "primary" part. No, I don't have primary screen set. Things should still work though, Plasma should simply remember which screen I put the panel on, not switch randomly. That's just not how X11/XRandr works. The only id we're storing for the moment is a numeric id and we'll restore these on every screens set the system is set on. We can design a new approach to the problem, but that definitely requires a bigger discussion. For the moment, you should be defining your xrandr settings properly, e.g. with KScreen (which I ported to KF5 last week, BTW). The bug itself remains valid, regardless of what we're currently doing or not. If I have three screens, one primary and two non-primary, the panels will switch randomly there and that's a bug. Panels and shells should stay on the screen I put them on, regardless of my xrandr setting. Having things switching randomly is unacceptable. Additional note: the RandR spec (including xrandr) does *explicitly* allow a configuration with no primary screen (there's xrandr --noprimary for that). KScreen also actually honors that by allowing to unselect the primary screen in the KCM. Finally, this is the system default configuration (I've never touched it since I've installed it). Having a setup with no primary screen is very valid and should be properly supported. Agreed, your patch that sorts from left to right fixes it. Let's get it rocking, once it honors primary screen and it keeps inserting screens in the correct place. Git commit b37948000e3844b85862a3b728447048d36d113f by Aleix Pol. Committed on 13/05/2014 at 15:04. Pushed by apol into branch 'master'. Improve predictability of plasma-shell screen id's So far we were just enforcing that 0 would be the primary screen. After this change we will make sure that the rest are layed out horizontally and then vertically if there's a 2 at the same position. If a new screen is connected, we'll try to put it in the correct position following the described situation. M +36 -44 shell/shellcorona.cpp M +1 -0 shell/shellcorona.h http://commits.kde.org/plasma-workspace/b37948000e3844b85862a3b728447048d36d113f Unfortunately this is still not fixed, containments still get placed at random during plasma loading. Here's a video with all code built 10 minutes ago: https://dl.dropboxusercontent.com/u/6761102/screencast-9.mkv Also Marco reports that the containments are always placed to the opposite screen than they were before. Git commit 9f9ba633c1f0525a62fa82e53ec0b68043d91277 by Aleix Pol. Committed on 14/05/2014 at 15:28. Pushed by apol into branch 'master'. Improve how the primary screens are sorted Only take it into account if the primary value is different in both screens M +2 -1 shell/shellcorona.cpp http://commits.kde.org/plasma-workspace/9f9ba633c1f0525a62fa82e53ec0b68043d91277 |