Bug 334437

Summary:	Rectangle brushes (block_basic) don't work well anymore (artefacts+incorrect ghost)
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ghevan
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/ccce1da59b798664c50217d7fdf5e485c6df216d	Version Fixed In:
Sentry Crash Report:

Description Bollebib 2014-05-06 20:06:28 UTC

from IRC

21:53:53 - Bollebib1: boud: block brushes seem to not work well,is this a known issue?
21:54:16 - boud: Bollebib1: I don't know...
21:54:18 - Bollebib1: square shaped brushes I mean
21:54:30 - Bollebib1: I had a few I used but the results seem odd ,now
21:54:50 - G-D-U has left the room (Quit: Ping timeout: 252 seconds).
21:54:57 - boud: Bollebib1: I started working through my bugzilla backlog on Saturday morning, but I had to go afk in the afternoon, and I haven't been on irc for real since then, I have such a backlog
21:55:01 - Animtim: I've a build from dmitryK's branch from a few days, first I'll check there if it happens too..
21:56:16 - boud: I guess I can confirm, and I might even be culprit
21:56:26 - Bollebib1: in stead of being a rectangle as it shows in the preview it shows as a square in the on-canvas rectangle
21:56:34 - Bollebib1: and the strokes thin out
21:57:31 - boud: yes, I see weirdness
21:57:42 - Animtim: boud: interesting, on this bbuild from dmitryK branch (git da3b27a), it doesn't happen.. so it's not a driver issue, but a change in master ;)
21:57:43 - Bollebib1: boud: which issue?
21:57:43 - Bollebib1: sorry I seem to have hijacked Animtim's complaint,and interupted with mine
21:58:39 - boud: Bollebib1: the rectangle brush one

Comment 1 vanyossi 2014-05-06 20:23:47 UTC

Brush outline seems to be affected by angle option. Make a square or circle brush with a ratio of < 0.20.

If angle around 0° or 180|
Outline renders exactly as tip preview

If angle around 90° or 270°
Brush outline deforms to the degree of becoming a square.

The problem seems to be in a rotation function. as deformation becomes steeper until 90 or 270 is reached and becomes less (perhaps even negative) in 0 and 180 degrees. It affects dynamic rotation as well.

Comment 2 Halla Rempt 2014-05-07 09:26:15 UTC

Git commit ccce1da59b798664c50217d7fdf5e485c6df216d by Boudewijn Rempt.
Committed on 07/05/2014 at 09:25.
Pushed by rempt into branch 'master'.

The default way of setting width and height from the brush tip image
is wrong for the autobrush.

M  +3    -3    krita/plugins/paintops/libbrush/kis_auto_brush.cpp
M  +1    -1    krita/plugins/paintops/libbrush/kis_brush.cpp

http://commits.kde.org/calligra/ccce1da59b798664c50217d7fdf5e485c6df216d