Summary: | Notes content is not persisted | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Grégoire Paris <postmaster> |
Component: | general | Assignee: | Ralf Habacker <ralf.habacker> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andi.fischer, okellogg, ralf.habacker |
Priority: | NOR | ||
Version: | 2.12.97 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/umbrello/911780cce5793208967ec729ce434b2f3b823f60 | Version Fixed In: | 4.13.1 |
Sentry Crash Report: |
Description
Grégoire Paris
2014-05-05 15:13:26 UTC
The problem here is that the documentation window content is not in sync with this documentation dialog. After closing the doc dialog the documentation window overwrites the widgets documentation. (In reply to comment #1) > The problem here is that the documentation window content is not in sync > with this documentation dialog. After closing the doc dialog the > documentation window overwrites the widgets documentation. The question is if we really need this additional documentation dialog ? We already have the documentation window, which - on a note widget double click - simply needs - to be set visible if not before, - to be focused and - the cursor placed into the edit field That would solve all this problems. (In reply to comment #2) > The question is if we really need this additional documentation dialog ? > We already have the documentation window, which - on a note widget double > click - simply needs > - to be set visible if not before, > - to be focused and > - the cursor placed into the edit field > Sounds good to me - simpler yet better. +1 If you have a lot of objects in your diagram you can simply click on the objects to see the documentation. That's much simpler than double clicking on an object and closing the dialog window again, which also hides your diagram. I have the hope, that this bug can be fixed maybe with a signal/slot mechanism. Do not remove a good feature -1 (In reply to comment #4) > If you have a lot of objects in your diagram you can simply click on the > objects to see the documentation. That's much simpler than double clicking > on an object and closing the dialog window again, which also hides your > diagram. > > I have the hope, that this bug can be fixed maybe with a signal/slot > mechanism. > > Do not remove a good feature > -1 I was not voting to remove the documentation window! On the contrary, I was voting to remove the extra popup dialog on double clicking on a note widget, and updating the doc window instead. (In reply to comment #2) > (In reply to comment #1) > > The problem here is that the documentation window content is not in sync > > with this documentation dialog. After closing the doc dialog the > > documentation window overwrites the widgets documentation. The problem is not bound to note widgets. It happens for *any* widget editing through the property window. Git commit 0481912e8bf08976ceeb10a820d81e99a6af6bcd by Ralf Habacker. Committed on 07/05/2014 at 15:01. Pushed by habacker into branch 'master'. Fix bug 'Notes content is not persistent.' The bug has been fixed by editing note widget text through the documentation window instead of the special note widget dialog. This commit open a way to use the documentation window as property editor. GUI M +0 -1 umbrello/CMakeLists.txt D +0 -74 umbrello/dialogs/notedialog.cpp D +0 -41 umbrello/dialogs/notedialog.h M +6 -0 umbrello/docwindow.cpp M +1 -0 umbrello/docwindow.h M +2 -10 umbrello/widgets/notewidget.cpp http://commits.kde.org/umbrello/0481912e8bf08976ceeb10a820d81e99a6af6bcd Git commit 911780cce5793208967ec729ce434b2f3b823f60 by Ralf Habacker. Committed on 07/05/2014 at 15:01. Pushed by habacker into branch 'KDE/4.13'. Fix bug 'Notes content is not persistent.' The bug has been fixed by editing note widget text through the documentation window instead of the special note widget dialog. This commit open a way to use the documentation window as property editor. FIXED-IN:4.13.1 GUI (cherry picked from commit 0481912e8bf08976ceeb10a820d81e99a6af6bcd) M +0 -1 umbrello/CMakeLists.txt D +0 -74 umbrello/dialogs/notedialog.cpp D +0 -41 umbrello/dialogs/notedialog.h M +6 -0 umbrello/docwindow.cpp M +1 -0 umbrello/docwindow.h M +2 -10 umbrello/widgets/notewidget.cpp http://commits.kde.org/umbrello/911780cce5793208967ec729ce434b2f3b823f60 |