Bug 334355

Summary:	Additional Information Dialog's scroll widget does not resize when the dialog is increased in size
Product:	[Applications] dolphin	Reporter:	Uzair Shamim <alanbortu>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	junior-jobs
Priority:	NOR
Version:	4.13.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-baseapps/f3f8450480e0063cb0e9268325aec695e41905cb	Version Fixed In:	4.13.2
Sentry Crash Report:
Attachments:	Widget not resizing

Description Uzair Shamim 2014-05-04 23:56:08 UTC

When I attempt to resize the dialog it resizes fine but the widget seems to have a hard coded max size so after a certain point it will no longer increase in size to use additional space. This is very annoying because the widget contains lots of items in it and it would be nice to be able to see them all without having to scroll.

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin
2. Click Control > Adjust View Properties > Additional Information
3. Increase the size of the dialog that pops up


Expected Results:  
The widget should resize to take up any additional space created.

openSUSE 13.1
KDE 4.13 from KDE:Current and Extra repos

Comment 1 Uzair Shamim 2014-05-04 23:57:19 UTC

Created attachment 86466 [details]
Widget not resizing

Comment 2 Frank Reininghaus 2014-05-05 07:15:40 UTC

Thanks for the report. It seems that this dialog was designed at a time when there was not that much additional information provided by Nepomuk/Baloo yet.

I think that removing the call that adds "stretch" to the layout of the additional information dialog (its source can be found in the "settings" subdirectory of Dolphin's source code) should be sufficient to fix this. Looks like a good junior job for potential new contributors.

Comment 3 Uzair Shamim 2014-05-10 00:22:15 UTC

Since it looks like no one else is assigned to do this, I would be willing to do this but where can I acquire the code for dolphin and how do I upload the changes as a patch?

Comment 4 Frank Reininghaus 2014-05-11 20:43:14 UTC

I've posted some information about Dolphin's development at

http://freininghaus.wordpress.com/2012/07/13/how-to-get-started-with-dolphin-development/

Most of it should still be accurate.

To obtain the source of Dolphin only (which is sufficient if you have kdelibs development packages installed), enter

git clone git://anongit.kde.org/kde-baseapps.git

in a shell. To build it, enter the kde-baseapps directory, then

mkdir build && cd build
cmake -DCMAKE_INSTALL_PREFIX=/path/where/dolphin/should/be/installed ..
make && make install

Comment 5 Uzair Shamim 2014-05-11 20:48:21 UTC

Thanks Frank, I will see what I can do :)

If someone else is reading this feel free to fix it, I am just trying this to get involved/learn.

Comment 6 Uzair Shamim 2014-05-11 21:31:22 UTC

I think you had the cmake command wrong, I was getting "CMake Error: The source directory "/home/gum/Development/dolphin" does not appear to contain CMakeLists.txt."

I changed it to 
cmake .. -DCMAKE_INSTALL_PREFIX=/path/to/location

and it worked

Comment 7 Frank Reininghaus 2014-05-13 17:01:54 UTC

Git commit f3f8450480e0063cb0e9268325aec695e41905cb by Frank Reininghaus, on behalf of Uzair Shamim.
Committed on 13/05/2014 at 16:56.
Pushed by freininghaus into branch 'KDE/4.13'.

Allow the widget in the "Additional Information" dialog to resize
REVIEW: 118088
FIXED-IN: 4.13.2

M  +0    -1    dolphin/src/settings/additionalinfodialog.cpp

http://commits.kde.org/kde-baseapps/f3f8450480e0063cb0e9268325aec695e41905cb