| Summary: | Some icons are not displayed | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Antonio Rojas <arojas> |
| Component: | Application Menu (Kicker) | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Screenshot
Kicker shot |
||
|
Description
Antonio Rojas
2014-05-04 14:35:39 UTC
Created attachment 86454 [details]
Screenshot
This is most likely a consequence of switching to QIconItem in the delegate, which has the advantage of being much faster than IconItem however. Created attachment 86468 [details]
Kicker shot
I can't reproduce the problem here; the apps that don't have icons on your shot have icons on my system.
I can reproduce in two different machines, but the applications whose icons are missing are different in each one Can you detect a pattern in the installation locations for the respective icons? Git commit ac2bb87986b3d941d17109fc7ea69e14e750803d by Eike Hein. Committed on 05/05/2014 at 12:22. Pushed by hein into branch 'master'. Move QIcon::fromTheme() out of delegate instanciation hotpath. M +3 -2 applets/kicker/plugin/abstractentry.h M +2 -2 applets/kicker/plugin/appsmodel.cpp M +1 -1 applets/kicker/plugin/recentdocsmodel.cpp M +1 -1 applets/kicker/plugin/rootmodel.cpp M +1 -1 applets/kicker/plugin/systemmodel.cpp http://commits.kde.org/plasma-desktop/ac2bb87986b3d941d17109fc7ea69e14e750803d Upfront: While I can't reproduce the problem with KMix et all, I noticed that Kicker doesn't show an icon for the Spotify client in my shot, while Kickoff does. The icon code is now identical to Kickoff's, though this doesn't actually change anything. Turns out the difference is in the icon *size*: Kickoff's icons are units.iconSizes.medium while Kicker's are units.iconSizes.small, and Spotify doesn't install a 16x16 icon. KDE used to scale down the next-larger size in the past, I think, but apparently no longer does, so the "no icon" fallback is used instead. *** This bug has been marked as a duplicate of bug 330845 *** |