Bug 334244

Summary:	Face tag zones are hidden after adding a new face
Product:	[Applications] digikam	Reporter:	Mathieu MD <mathieu>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, ddgreen, k, metzpinguin, mr.mahon.pl, msylwester, rjwgnr27, rjwgnr27, stephanolbrich
Priority:	NOR
Version:	4.12.0
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/4ea827bb0dee7827175abce4d6878a67bc3bfe11	Version Fixed In:	4.13.0
Sentry Crash Report:

Description Mathieu MD 2014-05-02 18:40:06 UTC

Adding a face tag zone while showing them will hide all of them.

Video demo: https://vidd.me/v/6Xy

Another bug shown in the video: using the mouse to click on a tag label does not work. I inputed <À> and mouse-clicked on <À IDENTIFIER>, which only closed the drop-down menu. I had to use the keyboard arrow-keys to select the label and press Enter.

Reproducible: Always

Steps to Reproduce:
1. Click the button to enable the display of existing face tags rectangles
2. Click the next button to add a new face tag, and add it
Actual Results:  
Previous rectangles, and the new created, just disappear. To show them again, you have to either select another photo and go back to this one, or disable then enable back the display of face tags.

Expected Results:  
Previous rectangles are still displayed, and the new one also.

Comment 1 Stephan Olbrich 2015-03-15 16:46:22 UTC

I can reproduce both issues in 4.8.0

Comment 2 Christian 2015-05-09 22:10:02 UTC

The face tag zone disappearing - it's probably the same issue as in bug 326033.

Comment 3 caulier.gilles 2015-05-09 22:14:03 UTC

*** Bug 326033 has been marked as a duplicate of this bug. ***

Comment 4 Maik Qualmann 2015-05-09 22:27:01 UTC

I had tried it some time ago and just tested again - not to reproduce here. Face tag zones are visible after added or remove other faces.

Maik

Comment 5 caulier.gilles 2015-05-11 09:11:51 UTC

In fact the face zone do not disappear. As you can see in video, when a face is registered, preview mode left face region editing and face tags are just hidden. Clicking on "Show Face Tags" show all face region tagged previously.

So the wish in this file is not to left face editor mode when a new region is entered. Right ?

Gilles Caulier

Comment 6 Christian 2015-05-11 15:17:31 UTC

Yes, that's right Gilles!
(It makes sense to continue showing the face tags after adding a new face tag, because that gives a confirmation that the user action was carried out successfully. Also, you actually have to hit the "Show face tags" button twice to make them come back - first click switches off the face tag zones that have already disappeared and the second click shows them again.)

Comment 7 rjwgnr27 2015-05-11 16:42:03 UTC

Hi Gilles,

Yes, that is correct, it should remain in editor mode, especially when there are multiple faces to be tagged.

Comment 8 mr.mahon.pl 2015-05-12 11:05:36 UTC

(In reply to Christian from comment #6)
> Yes, that's right Gilles!
> (It makes sense to continue showing the face tags after adding a new face
> tag, because that gives a confirmation that the user action was carried out
> successfully. Also, you actually have to hit the "Show face tags" button
> twice to make them come back - first click switches off the face tag zones
> that have already disappeared and the second click shows them again.)

Same here. The boxes disappear and I have to click twice to re-enable them.
Ubuntu and Mint here.

Comment 9 Daniel Green 2015-06-22 00:31:57 UTC

(In reply to mr.mahon.pl from comment #8)
> (In reply to Christian from comment #6)
> > Yes, that's right Gilles!
> > (It makes sense to continue showing the face tags after adding a new face
> > tag, because that gives a confirmation that the user action was carried out
> > successfully. Also, you actually have to hit the "Show face tags" button
> > twice to make them come back - first click switches off the face tag zones
> > that have already disappeared and the second click shows them again.)
> 
> Same here. The boxes disappear and I have to click twice to re-enable them.
> Ubuntu and Mint here.

Same here. Arch Linux and digiKam 4.11

Comment 10 Maik Qualmann 2015-06-22 06:00:57 UTC

Very strange, facial zones remain active with me. In the video, the error can also be seen so well. I could so far not reproduce.

Maik

Comment 11 Michal Sylwester 2015-08-15 22:42:13 UTC

Happens to me as well, however I think the actual trigger is saving/loading the metadata to image. Whenever I use "Write/Reread Metadata to/From Image" (btw: shouldn't from be lowercase?) the face tags become invisible and I have to go through the disable/enable steps.

Comment 12 Maik Qualmann 2015-08-16 10:41:16 UTC

Git commit 4ea827bb0dee7827175abce4d6878a67bc3bfe11 by Maik Qualmann.
Committed on 16/08/2015 at 10:32.
Pushed by mqualmann into branch 'master'.

fixed hidden face tag zones after add a new face and multiple signal / slot connections after preview images
FIXED-IN: 4.13.0

M  +2    -2    NEWS
M  +3    -3    app/views/imagepreviewview.cpp
M  +1    -1    utilities/facemanagement/facegroup.cpp

http://commits.kde.org/digikam/4ea827bb0dee7827175abce4d6878a67bc3bfe11

Comment 13 Maik Qualmann 2015-08-16 10:45:28 UTC

Thanks to Michal Sylwester for hint to saving/loading the metadata.

Maik

Comment 14 caulier.gilles 2015-08-18 20:50:09 UTC

Git commit 76ab4cb7cb3788ae11c38d491d145b368abbff5f by Gilles Caulier.
Committed on 18/08/2015 at 20:47.
Pushed by cgilles into branch 'frameworks'.

backport commit #4ea827bb0dee7827175abce4d6878a from git/master to frameworks branch

M  +3    -3    app/views/imagepreviewview.cpp
M  +5    -5    utilities/facemanagement/facegroup.cpp

http://commits.kde.org/digikam/76ab4cb7cb3788ae11c38d491d145b368abbff5f