Bug 334100

Summary: --page <number> being ignored
Product: [Applications] okular Reporter: Paul <pip.kde>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, jonathan.doman, kollix, pip.kde
Priority: NOR    
Version: 0.19.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: http://commits.kde.org/okular/61c830cb7a049f50ec654dacbfd128a36ef5740b Version Fixed In: 4.14.0
Sentry Crash Report:

Description Paul 2014-04-29 19:55:21 UTC 
Command line option  --page <number> is being ignored.

Okular is ignoring the page request and opens documents at either the first page or (for a document previously opened) the last opened page.

Further details on the openSUSE forum:
https://forums.opensuse.org/showthread.php/497605-Recent-update-%28-%29-broken-Okular-quot-open-at-page-quot

Possibly introduced by a recent update.
Okular - Version 0.19.0
Using KDE Development Platform 4.13.0

from openSUSE KDE:Current
4.13.0-3.1
Wed 23 Apr 2014 19:43:28 BST

Regards, Paul
Comment 1 Jonathan Doman 2014-04-29 20:59:50 UTC 
Thanks for reporting this - I can confirm that I broke this functionality. In fact, I think many of the command line options won't work properly. I'm happy to fix this, but it may be over a month until I have time to do so.
Comment 2 Paul 2014-04-30 10:21:53 UTC 
(In reply to comment #1)
> Thanks for reporting this - I can confirm that I broke this functionality. ...

:)  Things happen...  Thanks.
Comment 3 Christoph Feck 2014-06-23 20:01:22 UTC 
*** Bug 336609 has been marked as a duplicate of this bug. ***
Comment 4 Paul 2014-08-01 10:24:39 UTC 
(In reply to Jonathan Doman from comment #1)
> ... I'm happy to fix this, but it may be over a month until I have time
> to do so.

Any further timescale on this? The lack of "--page <number>" functionality rather breaks Recol's "snippet" feature, it would be good to have that working again :)
Comment 5 Albert Astals Cid 2014-08-03 13:08:46 UTC 
I'm working on a fix for this, should be up next week in time for 4.14.0
Comment 6 Paul 2014-08-03 16:02:50 UTC 
(In reply to Albert Astals Cid from comment #5)
> I'm working on a fix for this, should be up next week in time for 4.14.0

Fantastic! Many thanks, appreciate the effort you guys put in. :)
Comment 7 Albert Astals Cid 2014-08-03 20:00:56 UTC 
Big-ish patch up at https://git.reviewboard.kde.org/r/119595/
Comment 8 Albert Astals Cid 2014-08-08 20:38:14 UTC 
Git commit 61c830cb7a049f50ec654dacbfd128a36ef5740b by Albert Astals Cid.
Committed on 08/08/2014 at 20:35.
Pushed by aacid into branch 'KDE/4.14'.

Pass the command line options properly when using tabs or unique instances

Use a QString to serialize the command line options other than urls to open so it can be easily passed around to every place that opens a new shell or tab or overrides the content in a unique instance.
FIXED-IN: 4.14.0
REVIEW: 119595

M  +2    -1    conf/settings.kcfgc
M  +21   -16   core/document.cpp
M  +1    -0    core/document_p.h
M  +1    -0    shell/CMakeLists.txt
M  +17   -131  shell/main.cpp
M  +38   -44   shell/shell.cpp
M  +7    -9    shell/shell.h
M  +67   -0    shell/shellutils.cpp
M  +10   -0    shell/shellutils.h
M  +5    -0    tests/CMakeLists.txt

http://commits.kde.org/okular/61c830cb7a049f50ec654dacbfd128a36ef5740b