Bug 334099

Summary:	Compared to the equivalent Dolphin view, open/save dialog has excessive grid size in Simple/Icons view when labels are on the bottom
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Uzair Shamim <alanbortu>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	alanbortu, bugseforuns, kdelibs-bugs, nate
Priority:	NOR	Keywords:	junior-jobs, usability
Version:	5.44.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/bbc262674a56428d307da94aac87ca3e63500c54	Version Fixed In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	86838
Attachments:	A comparison between dolphin and file picker

Description Uzair Shamim 2014-04-29 19:37:35 UTC

Dolphin allows you to change the spacing between the items it displays so that you can increase or decrease it to your liking. All you have to do is Control > Configure Dolphin > View Modes > Width. However, the file picker (the dialog that opens when you have to select a file for a program, like when uploading an image with firefox) does not allow this behavior, which is very annoying because the defaults waste a lot of horizontal space. I will upload a screenshot showing the differences between the two.

Reproducible: Always

Steps to Reproduce:
1. Open Krita/Firefox/Any Program that makes use of the file picker
2. Attempt to open/Upload a file
3. Observe spacing difference
4. Compare with Dolphin settings (Control > Configure Dolphin > View Modes > Width)

Comment 1 Uzair Shamim 2014-04-29 19:38:34 UTC

Created attachment 86352 [details]
A comparison between dolphin and file picker

Comment 2 Nate Graham 2018-04-09 21:53:05 UTC

I think what you're asking for is not the ability to change the spacing, but rather that it should be better, like in Dolphin. Seems sensible and probably pretty easy.

Comment 3 null 2018-04-25 18:57:51 UTC

Git commit bbc262674a56428d307da94aac87ca3e63500c54 by Henrik Fehlauer, on behalf of Alex Nemeth.
Committed on 25/04/2018 at 18:57.
Pushed by rkflx into branch 'master'.

Improve grid icon layout in filepicker dialog

Summary:
Icon grid layout now changes depending on the dialog window size.

As a side effect, this patch improves the grid spacing in icons-on-top mode by making it looser for small icons (which gives the labels more space) and tighter for large icons (which allows more to be seen at once).
Fixed-IN: 5.46

Test Plan:
Before:

{F5811621}

After:

{F5811623}
{F5811625}

Works just as well when scaling is used:

{F5811628}

Reviewers: #frameworks, #vdg, ngraham, rkflx

Reviewed By: #vdg, ngraham, rkflx

Subscribers: abetts, rkflx, ngraham, #frameworks

Tags: #frameworks

Maniphest Tasks: T8552

Differential Revision: https://phabricator.kde.org/D12306

M  +20   -4    src/filewidgets/kdiroperator.cpp

https://commits.kde.org/kio/bbc262674a56428d307da94aac87ca3e63500c54