Bug 334084

Summary:	Regression with Overwrite Dialog
Product:	[Applications] umbrello	Reporter:	Ralf Habacker <ralf.habacker>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	2.11.5
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/umbrello/5d435935a88b92a4bd846d4e5fd6906377aac08f	Version Fixed In:	4.12.5
Sentry Crash Report:

Description Ralf Habacker 2014-04-29 14:04:18 UTC

Running menu entry Code->"Generate all code" shows a dialog with which the user can choose an overwrite policy from 3 available policies (overwrite, use similar name, do not overwrite). 
Because of a regression introduced in 2006 the dialog did not show the "use similar filename" option. 
Additional the dialogs return codes are not handled correctly,. which makes the "Apply to all remaining files" checkbox unusable. 






Reproducible: Always

Steps to Reproduce:
1. start umbrello
2. create some classes 
3. run "Generate all code" -> The "use similar name" button is not shown. 
4. check "Apply to all remaining files" checkbox 
5. click "overwrite" - > the dialog pops up again for the next file 
Actual Results:  



Expected Results:  
1. The  "use similar name" button should displayed
2. The  "Apply to all remaining files" checkbox should be honored.

Comment 1 Ralf Habacker 2014-04-29 14:07:35 UTC

Git commit 2de99c94f83d80b2723a9fb47ade7485687a29e6 by Ralf Habacker.
Committed on 29/04/2014 at 13:56.
Pushed by habacker into branch 'master'.

Regression fix: Show all defined buttons in OverwriteDialogue.

The regression has been introduced with commit 359986044b0af22616089bd93590a128fa21ba8a.

M  +1    -1    umbrello/dialogs/overwritedialogue.cpp

http://commits.kde.org/umbrello/2de99c94f83d80b2723a9fb47ade7485687a29e6

Comment 2 Ralf Habacker 2014-04-29 14:07:35 UTC

Git commit 12df38308d0a0b42b8cba1d0347e147fadb368d6 by Ralf Habacker.
Committed on 29/04/2014 at 13:59.
Pushed by habacker into branch 'master'.

Regression fix: Handle all return codes from OverwriteDialogue.

M  +2    -2    umbrello/codegenerators/simplecodegenerator.cpp

http://commits.kde.org/umbrello/12df38308d0a0b42b8cba1d0347e147fadb368d6

Comment 3 Ralf Habacker 2014-04-29 14:22:38 UTC

Git commit 773836136e982a7e6d7d63139ea5c4176d417476 by Ralf Habacker.
Committed on 29/04/2014 at 13:56.
Pushed by habacker into branch 'KDE/4.12'.

Regression fix: Show all defined buttons in OverwriteDialogue.

The regression has been introduced with commit 359986044b0af22616089bd93590a128fa21ba8a.
FIXED-IN:4.12.5
(cherry picked from commit 2de99c94f83d80b2723a9fb47ade7485687a29e6)

M  +1    -1    umbrello/dialogs/overwritedialogue.cpp

http://commits.kde.org/umbrello/773836136e982a7e6d7d63139ea5c4176d417476

Comment 4 Ralf Habacker 2014-04-29 14:22:38 UTC

Git commit 5d435935a88b92a4bd846d4e5fd6906377aac08f by Ralf Habacker.
Committed on 29/04/2014 at 13:59.
Pushed by habacker into branch 'KDE/4.12'.

Regression fix: Handle all return codes from OverwriteDialogue.
FIXED-IN:4.12.5
(cherry picked from commit 12df38308d0a0b42b8cba1d0347e147fadb368d6)

M  +2    -2    umbrello/codegenerators/simplecodegenerator.cpp

http://commits.kde.org/umbrello/5d435935a88b92a4bd846d4e5fd6906377aac08f

Comment 5 Ralf Habacker 2014-04-29 14:40:21 UTC

Git commit c40eb6b452a28f1e60f9ed85ed4dc92189312c3b by Ralf Habacker.
Committed on 29/04/2014 at 13:56.
Pushed by habacker into branch 'KDE/4.13'.

Regression fix: Show all defined buttons in OverwriteDialogue.

The regression has been introduced with commit 359986044b0af22616089bd93590a128fa21ba8a.
FIXED-IN:4.13.1
(cherry picked from commit 2de99c94f83d80b2723a9fb47ade7485687a29e6)

M  +1    -1    umbrello/dialogs/overwritedialogue.cpp

http://commits.kde.org/umbrello/c40eb6b452a28f1e60f9ed85ed4dc92189312c3b

Comment 6 Ralf Habacker 2014-04-29 14:40:40 UTC

Git commit cd0714e272d159743295229faf55a169ca72afb9 by Ralf Habacker.
Committed on 29/04/2014 at 13:59.
Pushed by habacker into branch 'KDE/4.13'.

Regression fix: Handle all return codes from OverwriteDialogue.
FIXED-IN:4.13.1
(cherry picked from commit 12df38308d0a0b42b8cba1d0347e147fadb368d6)

M  +2    -2    umbrello/codegenerators/simplecodegenerator.cpp

http://commits.kde.org/umbrello/cd0714e272d159743295229faf55a169ca72afb9

Comment 7 Oliver Kellogg 2022-12-19 05:56:55 UTC

Git commit 4b32d42d1ca614fe0cc7a09d7aeba61154ffb882 by Oliver Kellogg.
Committed on 19/12/2022 at 05:56.
Pushed by okellogg into branch 'master'.

umbrello/dialogs/singlepagedialogbase.h
- OverwriteDialog repurposes the Apply button to mean "No", therefore
  remove value No from enum ButtonCode.

umbrello/dialogs/overwritedialog.h
- Add static constant No as alias for SinglePageDialogBase::Apply.

M  +3    -1    umbrello/dialogs/overwritedialog.h
M  +2    -2    umbrello/dialogs/singlepagedialogbase.h

https://invent.kde.org/sdk/umbrello/commit/4b32d42d1ca614fe0cc7a09d7aeba61154ffb882