| Summary: | Dragon Player doesn't display the subtiltes anymore. | ||
|---|---|---|---|
| Product: | [Unmaintained] phonon-backend-gstreamer | Reporter: | Martin <martinjdg> |
| Component: | general | Assignee: | Daniel Vrátil <dvratil> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | myriam, romain.perier, sitter, tdfischer |
| Priority: | NOR | ||
| Version First Reported In: | 4.7.2 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/phonon-gstreamer/f5fa90dde334b988d75a70c5703a739641a311fc | Version Fixed/Implemented In: | 4.7.4 |
| Sentry Crash Report: | |||
|
Description
Martin
2014-04-24 03:02:59 UTC
In Dragon Player you might need to enable the subtitles manually. Anyway, reassigning to Dragon Player, as this is almost definitely not a phonon-gstreamer problem. auto detection is happening in gstreamer/mediaobject.cpp so bouncing back to pgst. (mind you, manual setting actually is not implemented in dragon, but that's a different issue altogether)
void MediaObject::autoDetectSubtitle()
{
if (m_source.type() == MediaSource::LocalFile ||
(m_source.type() == MediaSource::Url && m_source.mrl().scheme() == "file") ) {
QList<QLatin1String> exts = QList<QLatin1String>()
<< QLatin1String("sub") << QLatin1String("srt")
<< QLatin1String("smi") << QLatin1String("ssa")
<< QLatin1String("ass") << QLatin1String("asc");
// Remove the file extension
QString absCompleteBaseName = m_source.fileName();
absCompleteBaseName.replace(QFileInfo(absCompleteBaseName).suffix(), QChar());
// Looking for a subtitle in the same directory and matching the same name
foreach(const QLatin1String &ext, exts) {
if (QFile::exists(absCompleteBaseName + ext)) {
changeSubUri(Mrl("file://" + absCompleteBaseName + ext));
break;
}
}
}
}
Git commit f5fa90dde334b988d75a70c5703a739641a311fc by Dan Vrátil. Committed on 11/08/2014 at 16:48. Pushed by dvratil into branch '4.7'. Fix subtitles autodetection FIXED-IN: 4.7.4 M +6 -6 gstreamer/mediaobject.cpp http://commits.kde.org/phonon-gstreamer/f5fa90dde334b988d75a70c5703a739641a311fc |