Bug 333650

Summary:	DNS/Search DNS settings do not strip spaces from the comma delimited values
Product:	[Plasma] plasma-nm	Reporter:	janow49420
Component:	editor	Assignee:	Lukáš Tinkl <lukas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jgrulich
Priority:	NOR
Version:	0.9.3.3
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-nm/895602f228cf8fb7a7824256006db449e857eb48	Version Fixed In:
Attachments:	Spaces in the list not stripped

Description janow49420 2014-04-20 13:24:11 UTC

Spaces should be automatically stripped from the values in DNS Servers/Search Domains:

If someone enters this: example.com, example.net, example.org, example.edu
example.com
 example.net
 example.org
 example.edu

It does not make sense to have a space in a domain name so I don't see any reason in stripping it automatically if the user enters it.

Reproducible: Always

Comment 1 janow49420 2014-04-20 13:25:43 UTC

Created attachment 86182 [details]
Spaces in the list not stripped

Comment 2 Jan Grulich 2014-04-22 10:09:38 UTC

Git commit f2cdca6debf76ce2b96191e1209cbe0cfd1dbcd5 by Jan Grulich.
Committed on 22/04/2014 at 10:09.
Pushed by grulich into branch '0.9.3'.

Automatically strip spaces for DNS servers and domains

M  +19   -19   libs/editor/settings/ipv4widget.cpp
M  +2    -2    libs/editor/settings/ipv6widget.cpp

http://commits.kde.org/plasma-nm/f2cdca6debf76ce2b96191e1209cbe0cfd1dbcd5

Comment 3 Jan Grulich 2014-04-22 10:11:56 UTC

Git commit 895602f228cf8fb7a7824256006db449e857eb48 by Jan Grulich.
Committed on 22/04/2014 at 10:09.
Pushed by grulich into branch 'frameworks'.

Automatically strip spaces for DNS servers and domains

Conflicts:
	libs/editor/settings/ipv4widget.cpp
	libs/editor/settings/ipv6widget.cpp

M  +19   -19   libs/editor/settings/ipv4widget.cpp
M  +2    -2    libs/editor/settings/ipv6widget.cpp

http://commits.kde.org/plasma-nm/895602f228cf8fb7a7824256006db449e857eb48