| Summary: | Please add an option to display the GPS track loaded in the geolocation dialog [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Tobias Leupold <tl> |
| Component: | Geolocation-Correlator | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, johannes, justus, mike, tl |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kipi-plugins/be292493bfecc3caa41095b43c291de2d9556480 | Version Fixed In: | 4.1.0 |
| Sentry Crash Report: | |||
| Attachments: |
libkgeomap part of changes
gpssync part of changes |
||
|
Description
Tobias Leupold
2014-04-19 15:21:52 UTC
Reassigning to kipiplugins-gpssync; possibly related to bug #236533. Yes, this actually affects the KIPI-plugins, not KPA. Sorry, my fault. I did not find Bug #236533 in the first place. Actually, the reporter also requested displaying the GPX track amongst other things, but in the later comments, this is not mentioned anymore (additionally, the bug has been filed back in 2010 and it does not seem to be minded much …). I think the GPX track display could be added without considering the other UI makeovers demanded in Bug #236533, so probably it's reasonable to leave this in a separate bug. there was also bug 135386 which sounded like the feature you are taking about, but the solution did not look like what i expected. i just recently had the same need of seeing the tracks in the geolocation dialog and added it to my local checkout of kipiplugins and libkgeomap. i could post a patch even though it is not really polished. Why not? An unpolished patch is better than no patch ;-) Created attachment 86979 [details]
libkgeomap part of changes
Created attachment 86980 [details]
gpssync part of changes
all right. attached my changes. but they would need some polishing. i just went the shortest way to get the tracks shown (works for both in marble and google maps backend). comments are welcome.
Michael, Can you review and comment 2 patches attached to this entry about libkgeomap and GPSSync tool ? Thanks in advance Gilles Caulier Git commit 265b14d6404ece38f61a838e83d1d3f6f61d82f3 by Michael Georg Hansen. Committed on 04/06/2014 at 19:46. Pushed by mghansen into branch 'master'. Commit patch from Justus Schwartz to show GPX tracks on the map. M +48 -1 data/backend-googlemaps-js.js M +55 -2 demo/mainwindow.cpp M +22 -1 demo/mainwindow.h M +4 -1 libkgeomap/CMakeLists.txt M +4 -1 libkgeomap/backend_map.h M +62 -1 libkgeomap/backend_map_googlemaps.cpp M +8 -3 libkgeomap/backend_map_googlemaps.h M +60 -5 libkgeomap/backend_map_marble.cpp M +5 -1 libkgeomap/backend_map_marble.h M +6 -1 libkgeomap/kgeomap_common.h M +48 -1 libkgeomap/kgeomap_widget.cpp M +8 -1 libkgeomap/kgeomap_widget.h A +41 -0 libkgeomap/trackmodelhelper.cpp [License: GPL (v2+)] A +65 -0 libkgeomap/trackmodelhelper.h [License: GPL (v2+)] http://commits.kde.org/libkgeomap/265b14d6404ece38f61a838e83d1d3f6f61d82f3 Git commit d56a8b57a3b3ad0b6652f983c28785c48f4dabd6 by Michael Georg Hansen. Committed on 04/06/2014 at 19:47. Pushed by mghansen into branch 'master'. Commit patch from Justus Schwartz to show GPX tracks on the map. M +54 -1 gpssync/gpscorrelatorwidget.cpp M +8 -1 gpssync/gpscorrelatorwidget.h M +55 -1 gpssync/gpssyncdialog.cpp M +27 -1 gpssync/gpssyncdialog.h http://commits.kde.org/kipi-plugins/d56a8b57a3b3ad0b6652f983c28785c48f4dabd6 Micheal, Why this file is not closed now ? Gilles Hi Gilles, I forgot to close it ;-) Will do that now. Best regards, Michael Git commit be292493bfecc3caa41095b43c291de2d9556480 by Michael Georg Hansen. Committed on 05/06/2014 at 19:26. Pushed by mghansen into branch 'master'. Update NEWS. FIXED-IN: 4.1.0 M +4 -2 NEWS http://commits.kde.org/kipi-plugins/be292493bfecc3caa41095b43c291de2d9556480 |