Bug 333568

Summary:	Regression: Append signature in the composer dialog does not work
Product:	[Applications] kmail2	Reporter:	Christian Trippe <christiandehne>
Component:	composer	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	montel
Priority:	NOR
Version:	4.13
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:

Description Christian Trippe 2014-04-18 06:45:33 UTC

Configure a identy in kmail to have a signature but do not check the "enable signature" in that dialog.
Now write a mail for this identiy and try to add this signature via the menu -> attach -> append signature. No signature is attached. This worked fine with kmail from KDE 4.12 but does not work any longer with kmail from KDE 4.13

Automatically adding the signature to every mail when the "enable signature" button in the identiy configuration dialog is checked still works.

Reproducible: Always

Comment 1 Laurent Montel 2014-04-18 07:56:42 UTC

No it's not a regression
this:
 void Signature::insertIntoTextEdit( KRichTextEdit *textEdit,
                                     Placement placement, bool addSeparator )
 {
+  if(!isEnabledSignature()) {
+    return;
+  }
 was added in 4.9
=> it never worked when isEnabledSignature was unchecked.

Comment 2 Christian Trippe 2014-04-18 11:15:16 UTC

Thanks for the quick response.

I had to recreate the my pim settings for 4.13 during beta phase and apparently missed the extra "automatic append signature" configuration which is independent of the identy configuration dialog.

Everything works now as expected. Thanks for your work on kmail!

Comment 3 Laurent Montel 2014-04-18 11:23:14 UTC

Now in 4.13.1 I disable "append signature" when there is not signature or it's disable.
because before we clicked on it but it was disable => no action.

Regards