| Summary: | Implemented darker color, lighter color, inverted divide composite ops | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Odysseas <xb_creations> |
| Component: | File formats | Assignee: | Halla Rempt <halla> |
| Status: | RESOLVED WAITINGFORINFO | ||
| Severity: | normal | CC: | halla, sbrown655, xb_creations |
| Priority: | NOR | ||
| Version First Reported In: | 2.8.1 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | For testing: Psd file with all blending modes | ||
|
Description
Odysseas
2014-04-15 10:16:36 UTC
Created attachment 86110 [details]
For testing: Psd file with all blending modes
> link:
> http://www.odysseus-art.com/files/forums/misc/blending-modes-test.psd
PLEASE USE THE ATTACHMENT INSTEAD.
Thanks! Ah... I get an error loading that file in photoshop cs2 because it has an unsupported blending mode. Oh, sorry, missed the later comment. idiv = color burn = "inverted_divide": this one isn't implemented in Krita yet, so Normal gets subsituted darker color = normal lighter color = normal These two aren't supported in Photoshop CS2. Darker color is 'dkCl', lighter color 'lgCl'. I don't know what formula to use for these, though. From the current spec, I also see that fdiv and and fsub aren't in Krita -- and not in the test image either, as far as I can tell: http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577419_pgfId-27490 We're missing implementations for: inverted divide pass through darker color lighter color Git commit fe8a682cab8ce57608a66468d7d9a183d0e89af9 by Boudewijn Rempt. Committed on 23/08/2014 at 10:40. Pushed by rempt into branch 'master'. Fix the translation of photoshop blending modes We're still missing several blending modes, though. At least these are missing for rgb: inverted divide pass through darker color lighter color M +117 -51 krita/plugins/formats/psd/psd.cpp M +3 -0 libs/pigment/KoCompositeOpRegistry.h http://commits.kde.org/calligra/fe8a682cab8ce57608a66468d7d9a183d0e89af9 Git commit 39cbd4c2430dc931c4fffa4df268b86e6f29738e by Wolthera van Hovell. Committed on 12/05/2015 at 15:10. Pushed by woltherav into branch 'calligra/2.9'. Adds Lighter Color and Darker Color blending modes. We now only need the passthrough opp and the blending modes for PSD are done. Inverted divide is Color Burn, which in Krita we call 'Burn'. For MyPaint we'd still be missing one. Ref T258 M +2 -0 libs/pigment/KoCompositeOpRegistry.cpp M +4 -5 libs/pigment/KoCompositeOpRegistry.h M +36 -0 libs/pigment/compositeops/KoCompositeOpFunctions.h M +2 -0 libs/pigment/compositeops/KoCompositeOps.h http://commits.kde.org/calligra/39cbd4c2430dc931c4fffa4df268b86e6f29738e Git commit d77dbfbd263ba5a19d6318c4812656fd92c5e7be by Wolthera van Hovell. Committed on 12/05/2015 at 16:17. Pushed by woltherav into branch 'calligra/2.9'. Tell psd to use Burn for Color Burn, get rid of Inverted Divide nonsense This needs to be tested side by side with a Photoshop for rendering now. I don't trust how some of our blending modes are named... Ref T258 M +4 -4 krita/libpsd/psd.cpp M +1 -2 libs/pigment/KoCompositeOpRegistry.h http://commits.kde.org/calligra/d77dbfbd263ba5a19d6318c4812656fd92c5e7be Hi Odysseas, Could you check the latest Krita? We should be pretty complete now! |