| Summary: | Crash when doing code import. | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | pwagner9000 |
| Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | okellogg, ralf.habacker |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/umbrello/c2228a10e11a0ab5f37359a9f631d69228e9d5b3 | Version Fixed In: | 4.12.5 |
| Sentry Crash Report: | |||
|
Description
pwagner9000
2014-04-13 02:00:54 UTC
Please append a test case (In reply to comment #1) > Please append a test case Agreed, test case is necessary for a definitive fix. OTOH, looking at the backtrace, Thread 1 [...] #7 UMLAttribute::setInitialValue (this=0x0, iv=...) at attribute.cpp:110 #8 0x00000000004f7026 in AdaImport::parseStmt (this=0x2b316b0) at codeimport/adaimport.cpp:620 At adaimport.cpp:620 we have a dereference of 'attr' without preceding check for NULL pointer: 619 UMLAttribute *attr = static_cast<UMLAttribute*>(o); 620 attr->setInitialValue(initialValue); The crash is inevitable here (even without knowing the exact use case.) Git commit 3094593ec89e2fbb1505b3e1ee472c42b4d90826 by Ralf Habacker. Committed on 14/04/2014 at 08:53. Pushed by habacker into branch 'master'. Crash fix on ada import. M +4 -2 umbrello/codeimport/adaimport.cpp http://commits.kde.org/umbrello/3094593ec89e2fbb1505b3e1ee472c42b4d90826 Git commit 7ac0855f618f0bf32cf1a65eb9d27cf0c90540e1 by Ralf Habacker. Committed on 14/04/2014 at 08:53. Pushed by habacker into branch 'KDE/4.13'. Crash fix on ada import. FIXED-IN:4.13.0 (cherry picked from commit 3094593ec89e2fbb1505b3e1ee472c42b4d90826) M +4 -2 umbrello/codeimport/adaimport.cpp http://commits.kde.org/umbrello/7ac0855f618f0bf32cf1a65eb9d27cf0c90540e1 Git commit c2228a10e11a0ab5f37359a9f631d69228e9d5b3 by Ralf Habacker. Committed on 14/04/2014 at 08:53. Pushed by habacker into branch 'KDE/4.12'. Crash fix on ada import. FIXED-IN:4.12.5 (cherry picked from commit 3094593ec89e2fbb1505b3e1ee472c42b4d90826) M +4 -2 umbrello/codeimport/adaimport.cpp http://commits.kde.org/umbrello/c2228a10e11a0ab5f37359a9f631d69228e9d5b3 For the (In reply to comment #2) > (In reply to comment #1) > > Please append a test case > > Agreed, test case is necessary for a definitive fix. In the crash case the code importer writes in Import_Utils::insertAttribute() DEBUG(DBG_SRC) << "insertAttribute: Don not know what to do with " << owner->name() << " (object type " << UMLObject::toString(ot) << ")"; which indicates a issue with the parser or the related ada code. If this is a parser issue a related bug should be opened. Git commit 17abd847cb78dd6e895a490f3a6fc02fe0433cc0 by Oliver Kellogg. Committed on 08/05/2014 at 04:51. Pushed by okellogg into branch 'master'. umbrello/codeimport/adaimport.cpp - Fix crash on Ada import seen after primary crash cause was lifted (followup to commit 3094593) M +1 -1 umbrello/codeimport/adaimport.cpp http://commits.kde.org/umbrello/17abd847cb78dd6e895a490f3a6fc02fe0433cc0 Git commit 3b43de1ee590214b3fd26e3b5f749dc03525da1d by Oliver Kellogg. Committed on 08/05/2014 at 04:51. Pushed by okellogg into branch 'KDE/4.13'. umbrello/codeimport/adaimport.cpp - Fix crash on Ada import seen after primary crash cause was lifted (followup to commit 3094593) M +1 -1 umbrello/codeimport/adaimport.cpp http://commits.kde.org/umbrello/3b43de1ee590214b3fd26e3b5f749dc03525da1d |