| Summary: | Krita crashes when generating random noise with filter | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Spencer Brown <sbrown655> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | halla |
| Priority: | NOR | ||
| Version: | 2.9 Beta | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
attachment-20772-0.html
attachment-20772-1.dat noisefiltercrash.patch noisefilter.cpp |
||
|
Description
Spencer Brown
2014-04-07 02:41:51 UTC
Yes, I can confirm this filter is broken. It might make a good pre-gsoc exercise to try and fix it! Heh, I have to get caught up in school again after being ill all last week :( But I'll definitely take a crack at it. If you can reproduce it too it must not be that bad of a bug. Created attachment 86083 [details] attachment-20772-0.html OK, I've made a patch that will keep the noise filter from crashing. The crash was introduced on revision 22b92cc12aaa when we migrated to NG iterators. I haven't figured out why the noise filter doesn't like the sequential iterator, but it seems to work OK with the hline iterator instead. I've attached the patch and the revised file, so you can take your pick of which one you'd rather download. On Mon, Apr 7, 2014 at 3:03 AM, Boudewijn Rempt <boud@valdyas.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=333142 > > Boudewijn Rempt <boud@valdyas.org> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Status|UNCONFIRMED |CONFIRMED > CC| |boud@valdyas.org > Ever confirmed|0 |1 > > --- Comment #1 from Boudewijn Rempt <boud@valdyas.org> --- > Yes, I can confirm this filter is broken. It might make a good pre-gsoc > exercise to try and fix it! > > -- > You are receiving this mail because: > You reported the bug. > Created attachment 86084 [details]
attachment-20772-1.dat
Created attachment 86085 [details]
noisefiltercrash.patch
Created attachment 86086 [details]
noisefilter.cpp
Hm... Dmitry suggests, remove the for (int row...) loop completely. Then it should work. I think I tried that with the sequential iterator and it still crashed. But when I get back from class I can check it again. On Wed, Apr 16, 2014 at 7:17 AM, Boudewijn Rempt <boud@valdyas.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=333142 > > --- Comment #7 from Boudewijn Rempt <boud@valdyas.org> --- > Hm... Dmitry suggests, remove the for (int row...) loop completely. Then it > should work. > > -- > You are receiving this mail because: > You reported the bug. > I got around to trying it out and that fixes it. I applied for a KDE developer identity today, so if someone approves me I would be happy to push the change. Fixed in 55b3138686edae519c79b4c37b87c489f6fa2ebb |