| Summary: | i18n: word puzzle in KisShortcutConfiguration::buttonsToText, KisShortcutConfiguration::keysToText | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alexander Potashev <aspotashev> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, lueck |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/31c118ce72a4323d4976592eeaae09ee4f2f6e24 | Version Fixed In: | |
|
Description
Alexander Potashev
2014-04-06 20:54:16 UTC
I don't think this is fixable... I just checked the source and what happens here isn't that we're creating sentences, we're creating lists of things like mouse buttons. Boudewijn,
It's fixable in the following ways:
1. Make the separator (currently " + ") translatable.
2. Wrap the list and the string "Button"/"Buttons" (which stands for mouse buttons in buttonsToText()) in a single i18n() call, like i18nc("explain me", "%1 %2", listText, buttonsSuffix).
By doing so translators get a way to change "Left + Back Buttons" to "Buttons: Left, Back" or whatever is needed.
Added Burkhard to CC. Okay, I think I see. I would really appreciate a patch :-). But otherwise, I'll try and fix it this weekend. Git commit 03b280b0a43e59c88d012483f021cff70e2b1381 by Alexander Potashev. Committed on 14/04/2014 at 18:21. Pushed by aspotashev into branch 'master'. i18n: fix word puzzle in showing shortcut keys to the user M +10 -7 krita/ui/input/kis_shortcut_configuration.cpp http://commits.kde.org/calligra/03b280b0a43e59c88d012483f021cff70e2b1381 Git commit 92e99e34c20f88fd65290a6048c26fb621b984fb by Alexander Potashev. Committed on 14/04/2014 at 21:58. Pushed by aspotashev into branch 'master'. i18n: fix word puzzle mixing keys and mouse buttons of shortcut M +18 -14 krita/ui/input/kis_shortcut_configuration.cpp http://commits.kde.org/calligra/92e99e34c20f88fd65290a6048c26fb621b984fb Git commit 8e2712d416fb4733e4b02bd7d1c8349b2290788e by Boudewijn Rempt, on behalf of Alexander Potashev. Committed on 14/04/2014 at 21:58. Pushed by rempt into branch 'calligra/2.8'. i18n: fix word puzzle mixing keys and mouse buttons of shortcut M +18 -14 krita/ui/input/kis_shortcut_configuration.cpp http://commits.kde.org/calligra/8e2712d416fb4733e4b02bd7d1c8349b2290788e Git commit 31c118ce72a4323d4976592eeaae09ee4f2f6e24 by Boudewijn Rempt, on behalf of Alexander Potashev. Committed on 14/04/2014 at 18:21. Pushed by rempt into branch 'calligra/2.8'. i18n: fix word puzzle in showing shortcut keys to the user M +10 -7 krita/ui/input/kis_shortcut_configuration.cpp http://commits.kde.org/calligra/31c118ce72a4323d4976592eeaae09ee4f2f6e24 |