Bug 333092

Summary:	Kate forgets search results if multiple search tabs are active
Product:	[Applications] kate	Reporter:	Volkan <volkangezer>
Component:	search	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kare.sars
Priority:	NOR
Version First Reported In:	3.12.97
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kate/cc47ba960bbe296bccbccbf6722aa434a348e908	Version Fixed/Implemented In:	3.13 (KDE 4.13)
Sentry Crash Report:

Description Volkan 2014-04-05 13:43:44 UTC

I like using "Find in Files" feature of Kate. However, if we do multiple searches in multiple tabs, going to the previous searches gives no results.

Reproducible: Always

Steps to Reproduce:
1. Use find in files to do a search and wait it to be finished.
2. Click on new button to open new search tab
3. Search another term in the new tab and wait until it completes.
4. Click on the first tab to see the previous results
Actual Results:  
It shows zero results even though there were some results found.

Expected Results:  
It should show the previous results.

Comment 1 Kåre Särs 2014-04-05 19:31:44 UTC

Hi,
thanks for the report.

It seems that the plugin is doing a search in current file when the tab is changed, which it should not.. I'll have a look.

Comment 2 Kåre Särs 2014-04-05 20:20:22 UTC

Git commit 44ce3d0cb87f640348f8f657ac1c3b51273df87b by Kåre Särs.
Committed on 05/04/2014 at 20:15.
Pushed by sars into branch 'master'.

S&R: Do not trigger searchWhileTyping on result tab change
FIXED-IN: 3.13 (KDE 4.13)

M  +6    -0    addons/kate/search/plugin_search.cpp

http://commits.kde.org/kate/44ce3d0cb87f640348f8f657ac1c3b51273df87b

Comment 3 Kåre Särs 2014-04-05 20:26:01 UTC

Git commit cc2eb4a26dc27eee20b1b8376065a00be90fac2e by Kåre Särs.
Committed on 05/04/2014 at 20:15.
Pushed by sars into branch 'KDE/4.13'.

S&R: Do not trigger searchWhileTyping on result tab change
FIXED-IN: 3.13 (KDE 4.13)

M  +6    -0    addons/kate/search/plugin_search.cpp

http://commits.kde.org/kate/cc2eb4a26dc27eee20b1b8376065a00be90fac2e

Comment 4 Kåre Särs 2014-04-05 20:34:44 UTC

Git commit cc47ba960bbe296bccbccbf6722aa434a348e908 by Kåre Särs.
Committed on 05/04/2014 at 20:33.
Pushed by sars into branch 'frameworks'.

S&R: Do not trigger searchWhileTyping on result tab change
FIXED-IN: 3.13 (KDE 4.13)

M  +6    -0    addons/search/plugin_search.cpp

http://commits.kde.org/kate/cc47ba960bbe296bccbccbf6722aa434a348e908

Comment 5 Volkan 2014-11-27 22:34:33 UTC

I still experience this in KDE 4.14.1

Comment 6 Kåre Särs 2014-11-28 07:10:35 UTC

Hmm... I can not reproduce it.... 
Not with git nor with Kubuntu packages KDE 4.13.0 Kate 3.13.0

Are you sure you got Kate updated?

If you did I might need a more detailed steps to reproduce....

Comment 7 Volkan 2014-12-07 00:21:30 UTC

It says Kate version 3.14.1

Ok, yes you are right. It works. False alarm :).

The issue is now different, but I will open a new ticket for it.