Summary: | parley and dolphin crash simultaneously when images are dragged from dolphin to parley | ||
---|---|---|---|
Product: | [Applications] parley | Reporter: | Ansa <ansa.ansa> |
Component: | editor | Assignee: | parley bug tracker <parley-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | andxav, inge |
Priority: | NOR | ||
Version: | 0.9.4 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/parley/5d85ee98a93da6e352532a9a37beb0c6b30dbebd | Version Fixed In: | |
Sentry Crash Report: |
Description
Ansa
2014-04-04 14:16:45 UTC
Hi Ansa, It's definitely appropriate to open a new bug if the issue remains. Actually you could have told me and I would have reopened it for you but I thought you could do it too. Sorry. Hello Ansa, Thanks again for the clear bug report. I have proposed a patch in: https://git.reviewboard.kde.org/r/119125/ Git commit 5d85ee98a93da6e352532a9a37beb0c6b30dbebd by Andreas Xavier. Committed on 06/07/2014 at 17:13. Pushed by axavier into branch 'master'. Fixes bug 333076 parley and dolphin crash simultaneously when images are dragged from dolphin to parley Problem: Some dragdrop events don't contain any urls. The previous code assumed that all events contain at least one url and would crash when it accessed the non-existent QList[0] item. Patch: Checks that there is at least 1 url before using the first url. Note: I was unable to crash dolphin, but I think this is the same bug because the crash occurs on the exact same line as in Ansa's backtrace REVIEW: 119125 M +33 -25 src/editor/imagechooserwidget.cpp http://commits.kde.org/parley/5d85ee98a93da6e352532a9a37beb0c6b30dbebd |