Summary: | File -> Open Recent still present after disabling history | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | Matt Ruffalo <matt.ruffalo> |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, devel, majewsky, myriam, nate, null |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 4.13.0 rc1 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/gwenview/8bd2f625c67966ed9d32f98c74f769caf56f6fdd | Version Fixed In: |
Description
Matt Ruffalo
2014-03-31 12:36:46 UTC
Confirmed. Still a problem. *** Bug 324033 has been marked as a duplicate of this bug. *** It does not sound too complicated to implement (access the history setting before saving recent URLs, clear recent URLs from the config when closing the config dialog with checkbox unchecked). Git commit 8bd2f625c67966ed9d32f98c74f769caf56f6fdd by Peter Mühlenpfordt. Committed on 14/03/2018 at 08:22. Pushed by muhlenpfordt into branch 'master'. Prevent saving Recent Files and LastTargetDir if history is disabled Summary: Disabling history in {nav Settings > Configure > Advanced > History} does not prevent showing and populating {nav File > Open Recent}. The last target directory for Copy/Move/Link To dialog does not check for history option too. This patch only saves/restores file history if the option is enabled and hides the menu entry if disabled. Related: bug 391527 Depends on D11280 Test Plan: * Enable/disable history option * Open some images/folders in Gwenview * Copy/Move/Link To some images * Check if history is (not) saved/restored according to option value Reviewers: #gwenview, rkflx Reviewed By: #gwenview, rkflx Subscribers: rkflx Differential Revision: https://phabricator.kde.org/D11263 M +10 -4 app/mainwindow.cpp M +2 -1 lib/contextmanager.cpp https://commits.kde.org/gwenview/8bd2f625c67966ed9d32f98c74f769caf56f6fdd |