| Summary: | string problems: word puzzle, exclamation marks | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Alexander Potashev <aspotashev> |
| Component: | Usability-i18n | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 4.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kipi-plugins/8861ce38bcc21a985d309c4eded3e21a7cd8e35a | Version Fixed In: | 4.0.0 |
| Sentry Crash Report: | |||
Git commit 87a3f77e48f31e4f91b0748960fec8de82d0e8d1 by Gilles Caulier. Committed on 31/03/2014 at 09:02. Pushed by cgilles into branch 'master'. fix i18n rules. M +50 -25 photolayoutseditor/effects/PixelizePhotoEffect.cpp M +70 -53 photolayoutseditor/effects/PixelizePhotoEffect.h http://commits.kde.org/kipi-plugins/87a3f77e48f31e4f91b0748960fec8de82d0e8d1 Hi Gilles, This bug is not resolved yet, because the exclamation marks were not removed. BTW, is Digikam in string freeze at the moment? No yet string freeze. Only at 4.0.0-RC release http://www.digikam.org/about/releaseplan Gilles Caulier Git commit 8861ce38bcc21a985d309c4eded3e21a7cd8e35a by Gilles Caulier. Committed on 31/03/2014 at 12:54. Pushed by cgilles into branch 'master'. remove exlamation point from i18n M +1 -2 photolayoutseditor/widgets/canvas/Scene.cpp http://commits.kde.org/kipi-plugins/8861ce38bcc21a985d309c4eded3e21a7cd8e35a I guess, there still should be a full stop at the end of the sentence, in place of the exclamation point. |
Two problems: 1. at effects/PixelizePhotoEffect.cpp:123 return i18n("Pixelize [") + PIXEL_SIZE_STRING + '=' + QString::number(m_pixelSize) + ']'; Please use placeholders %1, %2, e.g. like this: i18n("Pixelize [%1=%2]", ...) 2. Please remove exclamation mark at widgets/canvas/Scene.cpp:1525 in string "Unable to create one element!" and its plural form. See http://techbase.kde.org/Projects/Usability/HIG/Exclamation_points Reproducible: Always