Bug 332793

On 30/03/14 05:23, Michael T. Garrison Stuber wrote:
> https://bugs.kde.org/show_bug.cgi?id=332793
>
>              Bug ID: 332793
>             Summary: Editing multiple transactions simultaneously wipes out
>                      amounts
>      Classification: Unclassified
>             Product: kmymoney4
>             Version: git master
>            Platform: Compiled Sources
>                  OS: Linux
>              Status: UNCONFIRMED
>            Severity: normal
>            Priority: NOR
>           Component: general
>            Assignee: kmymoney-devel@kde.org
>            Reporter: garrisonstuber@garriber.org
>
> Running the current master (Version 4.6.90-332a4957dd Using KDE Development
> Platform 4.11.5), if you edit multiple transactions and assign a new category,
> the amount is automatically set to zero.
>
> In case it's not obvious why this is a problem, consider that process of
> downloading credit card transactions from a bank.  Assigning multiple
> downloaded transactions to a given category is important for speed and
> usability, otherwise each transaction has to be edited one by one.  Not fun.
>
> Reproducible: Always
>
> Steps to Reproduce:
> 1.  Go into the ledger
> 2.  Select multiple transactions
> 3.  Change the category
>
> Actual Results:
> 4.  Amount value is set to zero.
> 5.  Save, and the previous values of all edited transactions are replaced with
> zero.
>
> Expected Results:
> 4.  Amount value stays blank
> 5.  Save, and the previous values of all edited transactions are retained.
> Only the category is updated.
>
> It's really, really tempting to label this bug "grave", as the way I used KMM,
> it absolutely kills my productivity.  Generally I'm loving the development
> release, but this is painful enough to the way I work, I may consider going
> back to 4.6.4 until it's fixed.
>


Strange.  I tried this first with a build from about a week ago, and 
then with the same build as you mention.  I don't see the clearing of 
any amounts, using existing transactions.  I also tried with a few 
imported files and again all worked as expected.

Allan

It does it consistently for me.   Before submitting the bug I did a git pull, make clean, make, and make install to ensure I had the latest code.

What's the best way for me to demonstrate this is happening?  (clearly if you can't reproduce it, you can't fix it.).  

Would a screen capture video help, or perhaps a sample file?  

--
Michael Garrison Stuber

> On Mar 30, 2014, at 11:12, Allan <agander93@gmail.com> wrote:
> 
>> On 30/03/14 05:23, Michael T. Garrison Stuber wrote:
>> https://bugs.kde.org/show_bug.cgi?id=332793
>> 
>>             Bug ID: 332793
>>            Summary: Editing multiple transactions simultaneously wipes out
>>                     amounts
>>     Classification: Unclassified
>>            Product: kmymoney4
>>            Version: git master
>>           Platform: Compiled Sources
>>                 OS: Linux
>>             Status: UNCONFIRMED
>>           Severity: normal
>>           Priority: NOR
>>          Component: general
>>           Assignee: kmymoney-devel@kde.org
>>           Reporter: garrisonstuber@garriber.org
>> 
>> Running the current master (Version 4.6.90-332a4957dd Using KDE Development
>> Platform 4.11.5), if you edit multiple transactions and assign a new category,
>> the amount is automatically set to zero.
>> 
>> In case it's not obvious why this is a problem, consider that process of
>> downloading credit card transactions from a bank.  Assigning multiple
>> downloaded transactions to a given category is important for speed and
>> usability, otherwise each transaction has to be edited one by one.  Not fun.
>> 
>> Reproducible: Always
>> 
>> Steps to Reproduce:
>> 1.  Go into the ledger
>> 2.  Select multiple transactions
>> 3.  Change the category
>> 
>> Actual Results:
>> 4.  Amount value is set to zero.
>> 5.  Save, and the previous values of all edited transactions are replaced with
>> zero.
>> 
>> Expected Results:
>> 4.  Amount value stays blank
>> 5.  Save, and the previous values of all edited transactions are retained.
>> Only the category is updated.
>> 
>> It's really, really tempting to label this bug "grave", as the way I used KMM,
>> it absolutely kills my productivity.  Generally I'm loving the development
>> release, but this is painful enough to the way I work, I may consider going
>> back to 4.6.4 until it's fixed.
> 
> 
> Strange.  I tried this first with a build from about a week ago, and then with the same build as you mention.  I don't see the clearing of any amounts, using existing transactions.  I also tried with a few imported files and again all worked as expected.
> 
> Allan

Just to ensure it wasn't something with my current data files, I created 
new file from scratch, and manually entered four transactions.  Every 
time I edit two or more transactions in one operation, this happens.

I recorded a video of what I'm doing and how KMM responds: 
https://www.youtube.com/watch?v=195z90l0XsI
Maybe this will help us understand the difference betwen what I'm seeing 
and what you're seeing.  I can also send you my dummy file if it's helpful.
>
> Strange.  I tried this first with a build from about a week ago, and 
> then with the same build as you mention.  I don't see the clearing of 
> any amounts, using existing transactions.  I also tried with a few 
> imported files and again all worked as expected.
>
> Allan

On 31/03/14 00:05, Michael T. Garrison Stuber wrote:
> https://bugs.kde.org/show_bug.cgi?id=332793
>
> --- Comment #3 from Michael T. Garrison Stuber <garrisonstuber@garriber.org> ---
> Just to ensure it wasn't something with my current data files, I created
> new file from scratch, and manually entered four transactions.  Every
> time I edit two or more transactions in one operation, this happens.
>
> I recorded a video of what I'm doing and how KMM responds:
> https://www.youtube.com/watch?v=195z90l0XsI
> Maybe this will help us understand the difference betwen what I'm seeing
> and what you're seeing.  I can also send you my dummy file if it's helpful.
>>
>> Strange.  I tried this first with a build from about a week ago, and
>> then with the same build as you mention.  I don't see the clearing of
>> any amounts, using existing transactions.  I also tried with a few
>> imported files and again all worked as expected.
>>
>> Allan
>

Still no go here.

Looking closely at your video, though, I see something interesting - two 
things in fact.

Having selected your two transactions, when you click Edit, all fields 
for both still shows their contents.  Here, when I edit, one transaction 
- the last clicked, I think - has all field blank.  Secondly, when you 
accept the edit, the two transactions that you selected are not the two 
that get cleared - oh, no, forget this one - their order has changed 
because the amounts changed.

Ah, wait.  I didn't notice at first.  I use in-line register display, 
and it was only when I tried forms mode and it showed your problem, only 
then did I notice that you are using forms mode.

So, I confirm your bug.  You might try register mode, to confirm for 
yourself that there is an avoidance.

Allan

Watched the video and noticed, that the amount field gets filled with 0.00 when the category changes. This is unexpected and causes the problem. I tried the following which worked here (in transaction form mode):

a) select two transactions
b) start edit
c) change category
d) remove value from amount field
e) enter the changes

btw: I noticed that the memo field does not stay empty during step b) above but have not checked if it has some implications.

On 31/03/14 07:45, Thomas Baumgart wrote:
> https://bugs.kde.org/show_bug.cgi?id=332793
>
> --- Comment #5 from Thomas Baumgart <ipwizard@users.sourceforge.net> ---
> Watched the video and noticed, that the amount field gets filled with 0.00 when
> the category changes. This is unexpected and causes the problem. I tried the
> following which worked here (in transaction form mode):
>
> a) select two transactions
> b) start edit
> c) change category
> d) remove value from amount field
> e) enter the changes
>
> btw: I noticed that the memo field does not stay empty during step b) above but
> have not checked if it has some implications.
>

I see a further issue.  On completion of the edit, the payee gets 
cleared too.

So far as the memo field is concerned, a while back I made a change 
following a couple of requests, to allow the memo to be cleared, as in 
empty rather than containing a space.  I decided to leave the memo field 
uncleared initially, so that the user could see what he was doing.

Allan

*** Bug 333498 has been marked as a duplicate of this bug. ***

*** Bug 333498 has been marked as a duplicate of this bug. ***

A workaround for this issue is to clear the text in the amount editor before entering the transactions.

Git commit 1a05ccce75b9cc0c47adeaefa2172a647e42d77d by Cristian Oneț.
Committed on 18/10/2014 at 10:10.
Pushed by conet into branch 'master'.

Don't update the amount when multiple transactions are selected.

M  +4    -0    kmymoney/dialogs/transactioneditor.cpp

http://commits.kde.org/kmymoney/1a05ccce75b9cc0c47adeaefa2172a647e42d77d

Git commit eceae0265be3a8e2d32aa90ae1a5bca487e48078 by Cristian Oneț.
Committed on 18/10/2014 at 10:10.
Pushed by conet into branch '4.7'.

Don't update the amount when multiple transactions are selected.

(cherry picked from commit 1a05ccce75b9cc0c47adeaefa2172a647e42d77d)

M  +4    -0    kmymoney/dialogs/transactioneditor.cpp

http://commits.kde.org/kmymoney/eceae0265be3a8e2d32aa90ae1a5bca487e48078