Bug 332692

Summary:	error message insufficient while trying to delete files bigger than the (preset) maximum size of trash
Product:	[Unmaintained] kio	Reporter:	whitedog
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arjunak234, frank78ac, gassaf
Priority:	NOR	Keywords:	junior-jobs
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kio/374dfab7c00568a8c38052728c33ac6b09fa5961	Version Fixed In:	5.10
Sentry Crash Report:

Description whitedog 2014-03-27 15:32:27 UTC

Actually sat in front of my machine, trying to delete an iso-dvd when the message 'pls cleanup trash manually' popped up. trash actually was empty and i still sat there wondering...

so i would like to suggest the following improvements to that dialogue:
1. an option to delete that file without moving it into the trash-folder anyways
2. a hint where to or overall change the behaviour of the limited trash size

at least the hint 'just do a shift-delete to get rid of that file' would have been helpful...

Reproducible: Always

Steps to Reproduce:
1. try to delete a file which is bigger than the preset value of max trash size (where for me it was not obvious that trash needed a size-setting anyways...)
2.
3.



i would say thats a point where the normal user is left alone, ok most actual unix-users know how to rm a file via shell but to make dolphin more user friendy esp if they just switched from a different os this is one of the in fact very small details but another effective one which will make people flee back to windows again ;))

Comment 1 whitedog 2014-03-27 15:43:11 UTC

PS: for people like me who within the last 30 yrs never ever used a trash to get things back and just got annoyed to delete things again it would be a very cool option to turn off trash function globally... ;) and yes - i know that the trash was one of the first and most remarkable options of desktops / GUI's and many wars happened around the style and that function itself...

Comment 2 Frank Reininghaus 2014-03-27 15:48:41 UTC

Thanks for the bug report. The KIO framework is responsible for moving files to the trash and deleting them, so I'll reassign. I'm not sure if the KIO parts of kdelibs or kio/trash in kde-runtime are responsible for the message.

P.S.: Please always tell us which version you are using when filing bug reports. Thanks.

Comment 3 Gilbert Assaf 2015-04-25 19:36:45 UTC

I did a small fix for this, see: https://git.reviewboard.kde.org/r/123500/

Comment 4 David Faure 2015-04-25 21:13:06 UTC

Git commit 374dfab7c00568a8c38052728c33ac6b09fa5961 by David Faure, on behalf of Gilbert Assaf.
Committed on 25/04/2015 at 21:12.
Pushed by dfaure into branch 'master'.

Better error message if a single file is too large for the trash
Change-Id: Ie043ca22a9495f2759a25f6a36d0d1aed7928491
REVIEW: 123500
FIXED-IN: 5.10

M  +12   -14   src/ioslaves/trash/trashimpl.cpp

http://commits.kde.org/kio/374dfab7c00568a8c38052728c33ac6b09fa5961