Bug 332666

Summary: Destructive actions without confirmation have non-editable key-bindings
Product: [Applications] konversation Reporter: cluebat <cluebat>
Component: generalAssignee: Konversation Developers <konversation-devel>
Status: RESOLVED FIXED    
Severity: normal CC: hein, peter.simonsson
Priority: NOR    
Version: 1.5   
Target Milestone: ---   
Platform: FreeBSD Ports   
OS: FreeBSD   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: patch to remove shortcut keys for destructive actions

Description cluebat 2014-03-27 02:09:48 UTC 
The key bindings for menu items appear to be non-editable as I can find nothing in Konversation preferences to change the hotkeys. Some of the actions are destructive (clearing scrollback and markers). Without confirmation or an ability to undo, these destructive actions are dangerous. The default key-bindings make it far too easy to accidentally trigger. Attempting to type a capital L, I slipped and bumped ctrl at the same time, results in loosing everything in all windows. It might as well have been an unconfirmed quit. These destructive actions are unlikely to be frequently used. It would be best if the user could choose the key-binding they want if any to trigger these actions. Short of that flexibility, it would be best to not have any key bindings at all so as to prevent accidental triggering and the ensuing frustration. I can't help but notice other functions (that might be more commonly used) e.g. Disconnect, have no key bindings. My simple solution for the moment is to follow suit and remove the shortcut keys for these destructive actions.
Comment 1 cluebat 2014-03-27 02:10:26 UTC 
Created attachment 85778 [details]
patch to remove shortcut keys for destructive actions
Comment 2 Eike Hein 2014-03-27 11:03:40 UTC 
Makes sense.
Comment 3 argonel 2014-03-27 16:45:19 UTC 
-1. this punishes the users who know about and use the shortcuts
Comment 4 cluebat 2014-03-27 21:08:23 UTC 
If there was a confirmation before clearing, some way to undo, or a way to edit the key bindings, then I wouldn't mind the shortcuts. As it is, these shortcuts punish mot only new users but anyone who dares make a typo. It took less than a week of use to accidentally discover these shortcuts. I looked for any other way to change them before making the patch. The use case is extremely minimal and there are other functions that are likely more frequently used that have no shortcut, so why attach shortcuts to functions with destructive potential and a minimal use case? Is there really anybody that needs to clear all their windows so frequently as to need a shortcut without even a confirmation? The function still exists in the menu for the rare occasion it may be useful. If anyone really wants to keep the shortcuts, then I implore them to provide an alternate patch which adds a confirmation. I compare this to a file manager that has select all and delete as a single function without confirmation. I don't think it's a stretch to say anyone with common sense would consider that bad design. The effect is the same, data is gone with no way to get it back.
Comment 5 Peter Simonsson 2016-09-11 07:39:20 UTC 
Closing this as the shortcuts are configurable under Settings->Configure Shortcuts...