| Summary: | Regression: baloo_file_extractor working while laptop is on battery, causing 100% load on multiple cores and thus draining the battery | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] Baloo | Reporter: | Christian (Fuchs) <kde> |
| Component: | Baloo File Daemon | Assignee: | Vishesh Handa <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arthur |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/baloo/96acbfd180a95e1b935bcb3d382cfa0e68d3e4ed | Version Fixed In: | |
|
Description
Christian (Fuchs)
2014-03-22 15:11:05 UTC
It works correctly for me. This could have been the result of a bug which caused multiple baloo_file_extractor processes to be spawned. It has been fixed. Otherwise the only reason that I can think of this happening is that if the extractor process is already running and then you move to battery, that process is not killed. Hmm, there can be another case as well. I'll look more into it. (In reply to comment #1) > It works correctly for me. This could have been the result of a bug which > caused multiple baloo_file_extractor processes to be spawned. It has been > fixed. If you have a .diff for me (or a pointer to the commit) I can check for you if I can reproduce it still with that. Or I can check after the release (which, I assume, contains the fix), as I don't know the release schedule by heart: if it can be fixed before the final tag, that would be nice of course, though. > Otherwise the only reason that I can think of this happening is that if the > extractor process is already running and then you move to battery, that > process is not killed. Hmm, there can be another case as well. I'll look > more into it. Unfortunately I don't have my notebook along, but I am 99% sure that the processes where already running before I unplugged the power, so that might very well be it. Are they supposed to be instantly killed? If not: it might be that they just kept running, as I have a couple of files which are huge (basically zips containing a _huge_ load of xml log files) this might have been the case. Thanks for looking into it :) Git commit 96acbfd180a95e1b935bcb3d382cfa0e68d3e4ed by Vishesh Handa. Committed on 25/04/2014 at 15:26. Pushed by vhanda into branch 'KDE/4.13'. FileIndexingJob: Pause it when on battery The FileIndexingJob normally just takes one iteration, except in the few exceptional cases when there is an offending file. In those cases, we try to call the extractor again with half those files, and keep splitting until we find the offending file. Normally, the file indexer is never run when on battery, so this patch just makes sure the error detection code is not run when on battery and the file indexer was already running. M +24 -3 src/file/fileindexingjob.cpp M +6 -0 src/file/fileindexingjob.h M +23 -5 src/file/fileindexingqueue.cpp M +5 -0 src/file/fileindexingqueue.h M +10 -0 src/file/indexingqueue.cpp M +2 -0 src/file/indexingqueue.h http://commits.kde.org/baloo/96acbfd180a95e1b935bcb3d382cfa0e68d3e4ed |